feat: add output_schema parameter to ai.generate()#2139
Merged
Conversation
chelsea-lin
reviewed
Oct 6, 2025
| @pytest.mark.parametrize( | ||
| ("sql", "expected"), | ||
| [ | ||
| ("x INT64", (pa.field("x", pa.int64()),)), |
Contributor
There was a problem hiding this comment.
Should we support lowercase dtype strings (e.g., "int64") for compatibility with pandas APIs like astype()
Contributor
Author
There was a problem hiding this comment.
Good point. Updated the parser to check the type strings in the case-insensitive way.
638037f to
780ff9f
Compare
chelsea-lin
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/446974666
I decided to create a local parser for transforming SQL type strings to PyArrow types. The code turned out to be not too difficult to write.
Plus, both the BigFrames and Ibis operators can deduct dtypes locally.