feat: implement inplace parameter for DataFrame.drop#2105
Merged
Conversation
This commit implements the `inplace` parameter for the `DataFrame.drop` method. When `inplace=True`, the DataFrame is modified in place and the method returns `None`. When `inplace=False` (the default), a new DataFrame is returned. Unit tests have been added to verify the functionality for both column and row dropping.
tswast
commented
Sep 22, 2025
Collaborator
Author
|
@jialuoo please take a look. I assigned to you because Shuowei is OOO. |
jialuoo
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the
inplaceparameter for theDataFrame.dropmethod.When
inplace=True, the DataFrame is modified in place and the method returnsNone. Wheninplace=False(the default), a new DataFrame is returned.Unit tests have been added to verify the functionality for both column and row dropping.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/385199126 🦕