feat: enhanced multimodal error handling with verbose mode for blob image functions#2024
Merged
feat: enhanced multimodal error handling with verbose mode for blob image functions#2024
Conversation
90e7d33 to
cde2a61
Compare
32fa87c to
623f9ba
Compare
1a873bc to
75d69a7
Compare
This reverts commit 9a5bcd2.
75d69a7 to
53528c7
Compare
sycai
reviewed
Oct 14, 2025
| check_index_type=False, | ||
| engine="pillow", connection=bq_connection, verbose=verbose | ||
| ) | ||
| if verbose: |
Contributor
There was a problem hiding this comment.
we usually don't put logics in unit tests: go/unit-testing-practices?polyglot=python#logic
In this case, we should use two test methods to avoid the "if-else" branch: test_blob_exif and text_blob_exif_verbose
The same suggestion applies to other test methods too.
Contributor
Author
There was a problem hiding this comment.
I have modified all testcases as suggested. I also checked the failed testcase. They are unrelated to this change.
sycai
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the changes:
Fixes #<403365429> 🦕