You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Maybe we should just warn if the decorator actually conflicts with the signature?
I considered that. While warning only on a signature conflict is an option, I'm concerned about the risk of users defining type hints in both the decorator and the function signature. Since this is just a warning and won't fail the execution, I lean toward warning users about any duplicated type hints too. What do you think?
Maybe we should just warn if the decorator actually conflicts with the signature?
I considered that. While warning only on a signature conflict is an option, I'm concerned about the risk of users defining type hints in both the decorator and the function signature. Since this is just a warning and won't fail the execution, I lean toward warning users about any duplicated type hints too. What do you think?
Per off-line discussion, we'll warn only the conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api: bigqueryIssues related to the googleapis/python-bigquery-dataframes API.size: mPull request size is medium.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/409565963.