chore: implement add_op and del_op compilers#1955
Merged
chelsea-lin merged 6 commits intomainfrom Aug 8, 2025
Merged
Conversation
product-auto-label
bot
added
size: m
sycai
reviewed
Jul 30, 2025
chelsea-lin
force-pushed
the
main_chelsealin_add
branch
from
d488892 to
8f5396a
Compare
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_add
branch
2 times, most recently
from
38b44fe to
3074a1f
Compare
sycai
reviewed
Aug 8, 2025
Comment on lines
+78
to
+85
| if dtypes.is_numeric(left.dtype) and dtypes.is_numeric(right.dtype): | ||
| left_expr = left.expr | ||
| if left.dtype == dtypes.BOOL_DTYPE: | ||
| left_expr = sge.Cast(this=left_expr, to="INT64") | ||
| right_expr = right.expr | ||
| if right.dtype == dtypes.BOOL_DTYPE: | ||
| right_expr = sge.Cast(this=right_expr, to="INT64") | ||
| return sge.Sub(this=left_expr, expression=right_expr) |
Contributor
There was a problem hiding this comment.
I think the boolean subtraction is not allowed either:
python-bigquery-dataframes/bigframes/operations/numeric_ops.py
Lines 201 to 202 in 51057fc
Contributor
Author
There was a problem hiding this comment.
Pandas does not allow both ops are bool types but allow one of ops is bool type: https://screenshot.googleplex.com/4Swcj3gUzMw9UWP
sycai
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 430133370 🦕