Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tswast
commented
Sep 18, 2025
| ) | ||
| ) | ||
|
|
||
| def __iter__(self) -> Iterable[Tuple[blocks.Label, df.DataFrame]]: |
Collaborator
Author
There was a problem hiding this comment.
This is very similar to series group by. I'll see if I can refactor.
Collaborator
Author
There was a problem hiding this comment.
Refactor complete. :-)
Collaborator
Author
|
e2e failures: These appear unrelated to this change. |
Collaborator
Author
|
doctest failure: This seems unrelated to the current change. |
shuoweil
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is a work in progress. We have two choices for the interface, and I find myself flip flopping between the two:
Return an iterable of pandas objects, similar toto_pandas_batches(). To make sure we end up with all the rows together, this would mean (a) create a struct of all non-grouped fields and (b)array_aggthose structs and (c) unpack those arrays and structs into DataFrame objects locally.After internal discussion, we settled on (2) because the groups could potentially be quite large.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal bug 383638782 🦕