Skip to content

chore!: support node 18 #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miguelvelezsa merged 52 commits into from
Nov 25, 2025
Merged

chore!: support node 18 #776

miguelvelezsa merged 52 commits into from
Nov 25, 2025

Conversation

@miguelvelezsa
Copy link
Contributor

@miguelvelezsa miguelvelezsa commented Nov 19, 2025

No description provided.

@miguelvelezsa miguelvelezsa requested review from a team as code owners November 19, 2025 00:26
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 19, 2025
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Nov 19, 2025
@generated-files-bot
Copy link

generated-files-bot bot commented Nov 19, 2025 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node14/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node14/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: s Pull request size is small. size: xs Pull request size is extra small. and removed size: xs Pull request size is extra small. size: s Pull request size is small. labels Nov 19, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 19, 2025
@miguelvelezsa miguelvelezsa added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 19, 2025
@miguelvelezsa miguelvelezsa changed the title feat!: support node 18 chore!: support node 18 Nov 24, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Nov 24, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 24, 2025
sofisl
sofisl previously approved these changes Nov 25, 2025
View reviewed changes
@miguelvelezsa miguelvelezsa merged commit f5e356a into main Nov 25, 2025
18 checks passed
@miguelvelezsa miguelvelezsa deleted the fix-tests branch November 25, 2025 18:09
@release-please release-please bot mentioned this pull request Nov 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sofisl sofisl sofisl approved these changes

@daniel-sanche daniel-sanche Awaiting requested review from daniel-sanche daniel-sanche is a code owner automatically assigned from googleapis/api-logging

Assignees

@daniel-sanche daniel-sanche

Labels

api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miguelvelezsa @sofisl @daniel-sanche