Skip to content

test: make bulkMutateIT less flaky #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mutianf merged 4 commits into from
May 7, 2026
+17 −22
Merged

test: make bulkMutateIT less flaky #2911

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42ab1dc
test: make bulk mutate it less flaky
mutianf May 7, 2026
1361199
Merge branch 'main' into flaky
mutianf May 7, 2026
df64317
fix
mutianf May 7, 2026
ef93bf5
Merge branch 'flaky' of github.com:mutianf/java-bigtable into flaky
mutianf May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 17 additions & 22 deletions google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/BulkMutateIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ public void testManyMutationsOnAuthorizedView() throws IOException, InterruptedE
.bulkMutateRowsSettings()
.setBatchingSettings(
batchingSettings.toBuilder().setDelayThreshold(Duration.ofHours(1)).build());
try (BigtableDataClient client = BigtableDataClient.create(settings);
Batcher<RowMutationEntry, Void> batcher =
client.newBulkMutationBatcher(
AuthorizedViewId.of(testEnvRule.env().getTableId(), testAuthorizedView.getId()))) {
try (BigtableDataClient client = BigtableDataClient.create(settings)) {
Batcher<RowMutationEntry, Void> batcher =
client.newBulkMutationBatcher(
AuthorizedViewId.of(testEnvRule.env().getTableId(), testAuthorizedView.getId()));
String familyId = testEnvRule.env().getFamilyId();
for (int i = 0; i < 2; i++) {
String key = rowPrefix + "test-key";
Expand All @@ -232,26 +232,21 @@ public void testManyMutationsOnAuthorizedView() throws IOException, InterruptedE
.first()
.call(Query.create(testEnvRule.env().getTableId()).rowKey(rowPrefix + "test-key"));
assertThat(row.getCells()).hasSize(100002);
}

// We should not be able to mutate rows outside the authorized view
try {
try (BigtableDataClient client = BigtableDataClient.create(settings);
Batcher<RowMutationEntry, Void> batcherOutsideAuthorizedView =
client.newBulkMutationBatcher(
AuthorizedViewId.of(
testEnvRule.env().getTableId().getTableId(), testAuthorizedView.getId()))) {
String keyOutsideAuthorizedView = UUID.randomUUID() + "-outside-authorized-view";
RowMutationEntry rowMutationEntry = RowMutationEntry.create(keyOutsideAuthorizedView);
rowMutationEntry.setCell(
testEnvRule.env().getFamilyId(), AUTHORIZED_VIEW_COLUMN_QUALIFIER, "test-value");
@SuppressWarnings("UnusedVariable")
ApiFuture<Void> ignored = batcherOutsideAuthorizedView.add(rowMutationEntry);
batcherOutsideAuthorizedView.flush();
// We should not be able to mutate rows outside the authorized view
String keyOutsideAuthorizedView = UUID.randomUUID() + "-outside-authorized-view";
RowMutationEntry rowMutationEntry = RowMutationEntry.create(keyOutsideAuthorizedView);
rowMutationEntry.setCell(
testEnvRule.env().getFamilyId(), AUTHORIZED_VIEW_COLUMN_QUALIFIER, "test-value");
try {
ApiFuture<Void> ignored = batcher.add(rowMutationEntry);
batcher.flush();
// error message is only thrown when closing the batcher
batcher.close();
fail("Should not be able to apply bulk mutation on rows outside authorized view");
} catch (Exception e) {
// ignore
}
fail("Should not be able to apply bulk mutation on rows outside authorized view");
} catch (Exception e) {
// Ignore.
}

testEnvRule
Expand Down
Loading