feat(storage): add builder and writer skeleton for open appendable object#5699
feat(storage): add builder and writer skeleton for open appendable object#5699vsharonlynn wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a skeleton implementation for appendable object uploads, including the OpenAppendableObject request builder and the AppendableObjectWriter utility. Feedback focuses on the structural requirement for the writer to hold a reference to the storage transport layer (the stub) to facilitate bidirectional streaming. Additionally, the reviewer noted that the use of #[allow(dead_code)] without a corresponding TODO or rationale violates the repository's style guide regarding temporary lint suppressions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5699 +/- ##
==========================================
- Coverage 97.91% 97.75% -0.16%
==========================================
Files 226 228 +2
Lines 55347 55647 +300
==========================================
+ Hits 54191 54398 +207
- Misses 1156 1249 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1eba40 to
71ef835
Compare
71ef835 to
68ebe33
Compare
This follows PR #5697.