Skip to content

feat(o11y): generate updated clients with populated LRO telemetry attributes#5629

Draft
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:lro-regenerate
Draft

feat(o11y): generate updated clients with populated LRO telemetry attributes#5629
haphungw wants to merge 1 commit into
googleapis:mainfrom
haphungw:lro-regenerate

Conversation

@haphungw
Copy link
Copy Markdown
Contributor

@haphungw haphungw commented May 8, 2026

sidekick was updated to populate telemetry attributes for google-cloud-lro. All new tracing code is gated behind the google_cloud_unstable_tracing flag.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (46ac7d8) to head (8359c0c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5629      +/-   ##
==========================================
- Coverage   97.89%   97.89%   -0.01%     
==========================================
  Files         226      226              
  Lines       55536    55536              
==========================================
- Hits        54369    54368       -1     
- Misses       1167     1168       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates generated code across multiple services to include tracing spans for long-running operation pollers and transitions to a more flexible poller initialization method. It also improves documentation examples for resource identifiers. Feedback identifies that the removal of specific link definitions in doc comments breaks existing references, suggesting a systematic generator issue. Additionally, it is recommended to use more robust tracing patterns like in_scope or .instrument instead of span.enter() to avoid potential issues in asynchronous contexts.

Comment thread src/generated/cloud/apigateway/v1/src/model.rs
Comment thread src/generated/api/apikeys/v2/src/builder.rs Outdated
@haphungw haphungw force-pushed the lro-regenerate branch 10 times, most recently from d3e3c82 to 40dfba3 Compare May 9, 2026 20:51
@haphungw haphungw force-pushed the lro-regenerate branch 2 times, most recently from addc5b3 to 23f1979 Compare May 11, 2026 16:03
haphungw added a commit to googleapis/librarian that referenced this pull request May 18, 2026
)

Introduce options plumbing in the generated stubs and dynamic decorators
to lay the foundation for LRO tracing.

Staged @ googleapis/google-cloud-rust#5629
@haphungw haphungw closed this May 18, 2026
@haphungw haphungw reopened this May 19, 2026
@haphungw haphungw force-pushed the lro-regenerate branch 10 times, most recently from 7c00064 to e6a36a0 Compare May 21, 2026 00:46
@haphungw haphungw changed the title feat(o11y): generate updated clients with LRO span creation feat(o11y): generate updated clients with populated LRO telemetry attributes May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant