feat(o11y): generate updated clients with populated LRO telemetry attributes#5629
feat(o11y): generate updated clients with populated LRO telemetry attributes#5629haphungw wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5629 +/- ##
==========================================
- Coverage 97.89% 97.89% -0.01%
==========================================
Files 226 226
Lines 55536 55536
==========================================
- Hits 54369 54368 -1
- Misses 1167 1168 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates generated code across multiple services to include tracing spans for long-running operation pollers and transitions to a more flexible poller initialization method. It also improves documentation examples for resource identifiers. Feedback identifies that the removal of specific link definitions in doc comments breaks existing references, suggesting a systematic generator issue. Additionally, it is recommended to use more robust tracing patterns like in_scope or .instrument instead of span.enter() to avoid potential issues in asynchronous contexts.
d3e3c82 to
40dfba3
Compare
addc5b3 to
23f1979
Compare
) Introduce options plumbing in the generated stubs and dynamic decorators to lay the foundation for LRO tracing. Staged @ googleapis/google-cloud-rust#5629
7c00064 to
e6a36a0
Compare
sidekickwas updated to populate telemetry attributes forgoogle-cloud-lro. All new tracing code is gated behind thegoogle_cloud_unstable_tracingflag.