Skip to content

fix(o11y): fill missing gaps for resource.destination.id #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
haphungw wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(o11y): fill missing gaps for resource.destination.id #5561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78acf9f
fix(o11y): fill missing gaps for resource identification id
haphungw Apr 29, 2026
724eb01
chore(storage): regenerate storage control clients with explicit anno…
haphungw May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ sources:
commit: 0e6dd9602b8f4a2fa119cd268eb01e82e762e08e
sha256: 4005f18049cc924eeacc4f060d96940202251de7ce65c92d361a3db5905b84e7
googleapis:
commit: 43731d5d22f8e3526ba7aa708da9d5de26043d0f
sha256: d146cfa257ffa00fc298ec7b6f73f9c7395a5a5ba050dcc553cfd78d6705bc3b
dir: /usr/local/google/home/haphung/googleapis
protobuf:
commit: b407e8416e3893036aee5af9a12bd9b6a0e2b2e6
sha256: 55912546338433f465a552e9ef09930c63b9eb697053937416890cff83a8622d
Expand Down Expand Up @@ -269,7 +268,7 @@ libraries:
match: |2
- `folders/<folder-number>`
- `organizations/<organization-number>`
replace: |+
replace: |
- `folders/<folder-number>`
- `organizations/<organization-number>`

Expand Down Expand Up @@ -1441,7 +1440,6 @@ libraries:
copyright_year: "2025"
output: src/storage
rust:
resource_name_heuristic: true
modules:
- module_path: crate::generated::gapic_control::model
name_overrides: .google.storage.control.v2.IntelligenceConfig.Filter.cloud_storage_buckets=CloudStorageBucketsOneOf,.google.storage.control.v2.IntelligenceConfig.Filter.cloud_storage_locations=CloudStorageLocationsOneOf
Expand Down
110 changes: 87 additions & 23 deletions src/generated/cloud/compute/v1/src/transport.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8577,11 +8577,18 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path = "/compute/v1/locations/global/firewallPolicies".to_string();
let path_template = "/compute/v1/locations/global/firewallPolicies";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.parent_id.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::POST, path);
let builder = req
.parent_id
Expand All @@ -8592,7 +8599,7 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
.iter()
.fold(builder, |builder, p| builder.query(&[("requestId", p)]));
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::POST, path_template)))
Some(builder.map(|b| (b, Method::POST, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -8606,7 +8613,8 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
recorder.on_client_request(
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.firewallPolicies/insert")
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand All @@ -8629,11 +8637,18 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path = "/compute/v1/locations/global/firewallPolicies".to_string();
let path_template = "/compute/v1/locations/global/firewallPolicies";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.parent_id.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::GET, path);
let builder = req
.filter
Expand Down Expand Up @@ -8662,7 +8677,7 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
builder.query(&[("returnPartialSuccess", p)])
});
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::GET, path_template)))
Some(builder.map(|b| (b, Method::GET, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -8676,7 +8691,8 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
recorder.on_client_request(
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.firewallPolicies/list")
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand All @@ -8699,13 +8715,20 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path =
"/compute/v1/locations/global/firewallPolicies/listAssociations".to_string();
let path_template =
"/compute/v1/locations/global/firewallPolicies/listAssociations";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.target_resource.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::GET, path);
let builder = req
.include_inherited_policies
Expand All @@ -8717,7 +8740,7 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
builder.query(&[("targetResource", p)])
});
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::GET, path_template)))
Some(builder.map(|b| (b, Method::GET, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -8731,7 +8754,8 @@ impl super::stub::FirewallPolicies for FirewallPolicies {
recorder.on_client_request(
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.firewallPolicies/listAssociations")
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand Down Expand Up @@ -13964,11 +13988,18 @@ impl super::stub::GlobalOrganizationOperations for GlobalOrganizationOperations
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path = "/compute/v1/locations/global/operations".to_string();
let path_template = "/compute/v1/locations/global/operations";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.parent_id.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::GET, path);
let builder = req
.filter
Expand Down Expand Up @@ -13997,7 +14028,7 @@ impl super::stub::GlobalOrganizationOperations for GlobalOrganizationOperations
builder.query(&[("returnPartialSuccess", p)])
});
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::GET, path_template)))
Some(builder.map(|b| (b, Method::GET, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -14011,7 +14042,8 @@ impl super::stub::GlobalOrganizationOperations for GlobalOrganizationOperations
recorder.on_client_request(
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.globalOrganizationOperations/list")
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand Down Expand Up @@ -42507,11 +42539,18 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path = "/compute/v1/locations/global/securityPolicies".to_string();
let path_template = "/compute/v1/locations/global/securityPolicies";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.parent_id.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::POST, path);
let builder = req
.parent_id
Expand All @@ -42522,7 +42561,7 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
.iter()
.fold(builder, |builder, p| builder.query(&[("requestId", p)]));
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::POST, path_template)))
Some(builder.map(|b| (b, Method::POST, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -42536,7 +42575,8 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
recorder.on_client_request(
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.organizationSecurityPolicies/insert")
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand All @@ -42559,11 +42599,18 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path = "/compute/v1/locations/global/securityPolicies".to_string();
let path_template = "/compute/v1/locations/global/securityPolicies";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.parent_id.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::GET, path);
let builder = req
.filter
Expand Down Expand Up @@ -42592,7 +42639,7 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
builder.query(&[("returnPartialSuccess", p)])
});
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::GET, path_template)))
Some(builder.map(|b| (b, Method::GET, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -42606,7 +42653,8 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
recorder.on_client_request(
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.organizationSecurityPolicies/list")
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand All @@ -42630,19 +42678,26 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path =
"/compute/v1/locations/global/securityPolicies/listAssociations".to_string();
let path_template =
"/compute/v1/locations/global/securityPolicies/listAssociations";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.target_resource.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::GET, path);
let builder = req.target_resource.iter().fold(builder, |builder, p| {
builder.query(&[("targetResource", p)])
});
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::GET, path_template)))
Some(builder.map(|b| (b, Method::GET, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -42658,7 +42713,8 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
.set_rpc_method(
"google.cloud.compute.v1.organizationSecurityPolicies/listAssociations",
)
.set_url_template(_path_template),
.set_url_template(_path_template)
.set_resource_name(_resource_name),
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand All @@ -42683,14 +42739,21 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
use gaxi::http::reqwest::{HeaderValue, Method};
use gaxi::path_parameter::PathMismatchBuilder;
use google_cloud_gax::error::binding::BindingError;
let (builder, method, _path_template) = None
let (builder, method, _path_template, _resource_name) = None
.or_else(|| {
let path =
"/compute/v1/locations/global/securityPolicies/listPreconfiguredExpressionSets"
.to_string();
let path_template =
"/compute/v1/locations/global/securityPolicies/listPreconfiguredExpressionSets";

let resource_name = format!(
"//compute.googleapis.com/{}",
Some(&req)
.and_then(|m| m.parent_id.as_ref())
.map(|s| s.as_str())
.unwrap_or(""),
);
let builder = self.inner.builder(Method::GET, path);
let builder = req
.filter
Expand Down Expand Up @@ -42719,7 +42782,7 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
builder.query(&[("returnPartialSuccess", p)])
});
let builder = Ok(builder);
Some(builder.map(|b| (b, Method::GET, path_template)))
Some(builder.map(|b| (b, Method::GET, path_template, resource_name)))
})
.ok_or_else(|| {
let mut paths = Vec::new();
Expand All @@ -42734,6 +42797,7 @@ impl super::stub::OrganizationSecurityPolicies for OrganizationSecurityPolicies
gaxi::observability::ClientRequestAttributes::default()
.set_rpc_method("google.cloud.compute.v1.organizationSecurityPolicies/listPreconfiguredExpressionSets")
.set_url_template(_path_template)
.set_resource_name(_resource_name)
);
}
let options = google_cloud_gax::options::internal::set_default_idempotency(
Expand Down
Loading
Loading