test(pubsub): fail on panics in subscriber#4803
Open
dbolduc wants to merge 1 commit intogoogleapis:mainfrom
Open
test(pubsub): fail on panics in subscriber#4803dbolduc wants to merge 1 commit intogoogleapis:mainfrom
dbolduc wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 94.98% 95.01% +0.02%
==========================================
Files 204 204
Lines 7877 7877
==========================================
+ Hits 7482 7484 +2
+ Misses 395 393 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Feb 25, 2026
Collaborator
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
AFAICT this makes some tests more strict. Ship it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #4519 and #3975 and #3964
These tests all involve background tasks, none of which should panic.
Credit to @PhongChuong for figuring out how to do this.