feat(spanner): [WIP] support data client#4701
Draft
olavloite wants to merge 11 commits intogoogleapis:mainfrom
Draft
feat(spanner): [WIP] support data client#4701olavloite wants to merge 11 commits intogoogleapis:mainfrom
olavloite wants to merge 11 commits intogoogleapis:mainfrom
Conversation
Add a data-plane client for Spanner.
Collaborator
|
/gcbrun |
coryan
requested changes
Feb 16, 2026
Collaborator
coryan
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think you can skip the grpc-mock subdirectory in the first PR and things will be easier to review and merge.
Also filed googleapis/librarian#4073 because the grpc-mock thing is tedious. Do not worry, I believe we should continue to make progress with this PR (maybe split in smaller PRs) and leave the sidekick automation for later.
src/spanner/grpc-mock/protos/google/api/apikeys/v2/apikeys_grpc_service_config.json
Outdated
Show resolved
Hide resolved
src/spanner/grpc-mock/protos/google/api/apikeys/v2/apikeys_v2.yaml
Outdated
Show resolved
Hide resolved
src/spanner/grpc-mock/protos/google/api/expr/conformance/v1alpha1/BUILD.bazel
Outdated
Show resolved
Hide resolved
src/spanner/grpc-mock/protos/google/api/servicecontrol/v2/service_controller.proto
Outdated
Show resolved
Hide resolved
.../grpc-mock/protos/google/api/servicemanagement/v1/servicemanagement_grpc_service_config.json
Outdated
Show resolved
Hide resolved
src/spanner/grpc-mock/protos/google/spanner/admin/instance/v1/BUILD.bazel
Outdated
Show resolved
Hide resolved
Collaborator
|
/gcbrun |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4701 +/- ##
==========================================
- Coverage 95.05% 90.25% -4.80%
==========================================
Files 198 208 +10
Lines 7581 7984 +403
==========================================
Hits 7206 7206
- Misses 375 778 +403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aae7512 to
4efe012
Compare
58de901 to
671519a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WORK IN PROGRESS]
Add a data-plane client for Spanner.
Depends on googleapis/librarian#4072