Skip to content

Comments

feat(gax): bump version to 1.8#4695

Open
vsharonlynn wants to merge 2 commits intogoogleapis:mainfrom
vsharonlynn:feat/bump-gax-version
Open

feat(gax): bump version to 1.8#4695
vsharonlynn wants to merge 2 commits intogoogleapis:mainfrom
vsharonlynn:feat/bump-gax-version

Conversation

@vsharonlynn
Copy link
Contributor

Bumps google-cloud-gax to 1.7

Splitting version bump from PR #4601 as requested in this comment.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.07%. Comparing base (dc8585f) to head (fcc6df0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4695      +/-   ##
==========================================
+ Coverage   95.06%   95.07%   +0.01%     
==========================================
  Files         198      198              
  Lines        7598     7598              
==========================================
+ Hits         7223     7224       +1     
+ Misses        375      374       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn vsharonlynn marked this pull request as ready for review February 16, 2026 04:14
@vsharonlynn vsharonlynn requested a review from a team as a code owner February 16, 2026 04:14
@coryan
Copy link
Collaborator

coryan commented Feb 16, 2026

Bumps google-cloud-gax to 1.7

This is a good idea, but won't help with this comment:

Splitting version bump from PR #4601 as requested in this comment.

*-gax@1.7 was recently released. You are about to add new functionality (which will require a bump to 1.8) and then use a new functionality in *-gax-internal. You will need to bump this again to 1.8 when that happens.

@vsharonlynn vsharonlynn force-pushed the feat/bump-gax-version branch from 0a82670 to fcc6df0 Compare February 19, 2026 02:05
@vsharonlynn vsharonlynn changed the title feat(gax): bump version to 1.7 feat(gax): bump version to 1.8 Feb 19, 2026
@coryan
Copy link
Collaborator

coryan commented Feb 19, 2026

Sorry, I should have thought of this earlier. It may be easier to follow the instructions here:

https://github.com/googleapis/google-cloud-rust/blob/main/doc/contributor/howto-guide-generated-code-maintenance.md#bump-all-version-numbers

In general, it may be better to start by adding the functionality to google-cloud-gax and then bumping the version numbers. Otherwise we signal to consumers of the crate that something changed, when it has not.

coryan
coryan previously approved these changes Feb 19, 2026
Copy link
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you would rather merge these manual changes or try the how-to guide. I am fine with either.

@vsharonlynn
Copy link
Contributor Author

Sorry, I should have thought of this earlier. It may be easier to follow the instructions here:

https://github.com/googleapis/google-cloud-rust/blob/main/doc/contributor/howto-guide-generated-code-maintenance.md#bump-all-version-numbers

In general, it may be better to start by adding the functionality to google-cloud-gax and then bumping the version numbers. Otherwise we signal to consumers of the crate that something changed, when it has not.

Ok! We will do this in order:

  1. @joshuatants will submit the functionalities.
  2. I will use the how-to guide to bump the version number for gax library.

Thanks @coryan !

@coryan coryan dismissed their stale review February 19, 2026 04:50

Will approve again once the new functionality is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants