Skip to content

Conversation

@gadekarnitesh
Copy link
Contributor

docs(guide): fix broken LRO links in compute.md

Update links for "Working with long-running operations" and
"Configuring polling policies" to point to correct relative paths
in lro.md instead of non-existent absolute paths.

@gadekarnitesh gadekarnitesh requested a review from a team as a code owner December 25, 2025 08:06
@google-cla
Copy link

google-cla bot commented Dec 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dbolduc
Copy link
Member

dbolduc commented Dec 30, 2025

/gcbrun

@dbolduc dbolduc self-requested a review December 30, 2025 16:51
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (76070ae) to head (76613f4).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4126      +/-   ##
==========================================
+ Coverage   94.78%   94.80%   +0.01%     
==========================================
  Files         182      182              
  Lines        6885     6885              
==========================================
+ Hits         6526     6527       +1     
+ Misses        359      358       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totally right. Thanks for the fix.

Our markdown formatter linter is unhappy with the capitalization / order of the links though. Can you reformat?

--- a/guide/src/compute.md
+++ b/guide/src/compute.md
@@ -52,7 +52,7 @@ can list all the VMs in a project using the `list()` function of this type:
 
 [billing enabled]: https://cloud.google.com/billing/docs/how-to/verify-billing-enabled#confirm_billing_is_enabled_on_a_project
 [compute engine]: https://cloud.google.com/compute
+[compute engine client libraries]: https://cloud.google.com/compute/docs/api/libraries
+[configuring polling policies]: configuring_polling_policies.md
 [google cloud project]: https://cloud.google.com/resource-manager/docs/creating-managing-projects
-[Compute Engine client libraries]: https://cloud.google.com/compute/docs/api/libraries
 [working with long-running operations]: working_with_long_running_operations.md
-[configuring polling policies]: configuring_polling_policies.md

@dbolduc
Copy link
Member

dbolduc commented Dec 31, 2025

/gcbrun

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coryan coryan merged commit 1830c77 into googleapis:main Jan 1, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants