-
Notifications
You must be signed in to change notification settings - Fork 99
test: generate diff - do not merge #4121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: test-prep
Are you sure you want to change the base?
Conversation
| /// The service that an application uses to manipulate topics, and to send | ||
| /// messages to a topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found exact source in googleapis: https://github.com/googleapis/googleapis/blob/ef6a532bfd9ab7a944bdedd64c69a2b4042db58b/google/pubsub/v1/pubsub.proto#L45-L46
Seems that the current content in google-cloud-rust is off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes we intervene in the comments:
| [[documentation-overrides]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these override are not included in migrated librarian.yaml:
google-cloud-rust/src/pubsub/src/generated/gapic/.sidekick.toml
Lines 50 to 60 in cde7484
| # Documentation overrides specific to the Rust clients. | |
| # Dataplane operations are excluded from the TopicAdmin and SubscriptionAdmin clients. | |
| [[documentation-overrides]] | |
| id = ".google.pubsub.v1.Publisher" | |
| match = "The service that an application uses to manipulate topics, and to send\nmessages to a topic." | |
| replace = "The service that an application uses to manipulate topics." | |
| [[documentation-overrides]] | |
| id = ".google.pubsub.v1.Subscriber" | |
| match = "The service that an application uses to manipulate subscriptions and to\nconsume messages from a subscription via the `Pull` method or by\nestablishing a bi-directional stream using the `StreamingPull` method." | |
| replace = "The service that an application uses to manipulate subscriptions." |
| /// The service that an application uses to manipulate subscriptions and to | ||
| /// consume messages from a subscription via the `Pull` method or by | ||
| /// establishing a bi-directional stream using the `StreamingPull` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /// | ||
| /// ```norust | ||
| /// - "projects/<project-id>", e.g. "projects/tokyo-rain-123" | ||
| /// - "folders/<folder-id>", e.g. "folders/1234" | ||
| /// - "organizations/<organization-id>", e.g. "organizations/1234" | ||
| /// ``` | ||
| /// | ||
| /// The `supports_under` field of the associated `Constraint` defines whether | ||
| /// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ldetmer do you think this in anyway related to googleapis/librarian#3284?
|
Aside: is it possible to work out of a fork, instead of branching in the We try not to pollute the branches in the main repository. And I am not sure we have the right branch protections in place. |
This is a test PR to show differences in
librarian generate --allfromsidekick refresh-all.For more context googleapis/librarian#3330