Skip to content

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Dec 23, 2025

This is a test PR to show differences in librarian generate --all from sidekick refresh-all.
For more context googleapis/librarian#3330

Comment on lines +32 to +33
/// The service that an application uses to manipulate topics, and to send
/// messages to a topic.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found exact source in googleapis: https://github.com/googleapis/googleapis/blob/ef6a532bfd9ab7a944bdedd64c69a2b4042db58b/google/pubsub/v1/pubsub.proto#L45-L46

Seems that the current content in google-cloud-rust is off?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes we intervene in the comments:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these override are not included in migrated librarian.yaml:

# Documentation overrides specific to the Rust clients.
# Dataplane operations are excluded from the TopicAdmin and SubscriptionAdmin clients.
[[documentation-overrides]]
id = ".google.pubsub.v1.Publisher"
match = "The service that an application uses to manipulate topics, and to send\nmessages to a topic."
replace = "The service that an application uses to manipulate topics."
[[documentation-overrides]]
id = ".google.pubsub.v1.Subscriber"
match = "The service that an application uses to manipulate subscriptions and to\nconsume messages from a subscription via the `Pull` method or by\nestablishing a bi-directional stream using the `StreamingPull` method."
replace = "The service that an application uses to manipulate subscriptions."

Comment on lines +301 to +303
/// The service that an application uses to manipulate subscriptions and to
/// consume messages from a subscription via the `Pull` method or by
/// establishing a bi-directional stream using the `StreamingPull` method.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +323 to +331
///
/// ```norust
/// - "projects/<project-id>", e.g. "projects/tokyo-rain-123"
/// - "folders/<folder-id>", e.g. "folders/1234"
/// - "organizations/<organization-id>", e.g. "organizations/1234"
/// ```
///
/// The `supports_under` field of the associated `Constraint` defines whether
///
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldetmer do you think this in anyway related to googleapis/librarian#3284?

zhumin8 added a commit that referenced this pull request Dec 23, 2025
This file looks like a leftover from
#198. Other
placeholder files created in the same PR were removed, e.g.
src/generated/type/src/main.rs,
src/generated/cloud/secretmanager/v1/src/main.rs.

Encountered this file when comparing generate results, see
#4121.
@dbolduc
Copy link
Member

dbolduc commented Dec 23, 2025

Aside: is it possible to work out of a fork, instead of branching in the googleapis/google-cloud-rust repo?

We try not to pollute the branches in the main repository.

And I am not sure we have the right branch protections in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants