Skip to content

chore: test CommonResource resource name alias #16965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 2 commits into from
May 6, 2026
+30 −0
Merged

chore: test CommonResource resource name alias #16965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b03d81
chore: test CommonResource resource name alias
ohmayr May 6, 2026
da3c190
add newline
ohmayr May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/gapic-generator/tests/unit/schema/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4499,3 +4499,33 @@ def test_method_settings_invalid_multiple_issues():
assert re.match(".*squid.*not.*uuid4.*", error_yaml[method_example1][1].lower())
assert re.match(".*octopus.*not.*uuid4.*", error_yaml[method_example1][2].lower())
assert re.match(".*method.*not found.*", error_yaml[method_example2][0].lower())


def test_file_level_resources_with_aliases():
"""Proves that CLI aliases are passed down to file-level CommonResources."""
fdp = make_file_pb2(
name="nomenclature.proto",
package="nomenclature.linneaen.v1",
messages=(
make_message_pb2(
name="CreateSpeciesRequest",
fields=(make_field_pb2(name="species", number=1, type=9),),
),
),
)
res_pb2 = fdp.options.Extensions[resource_pb2.resource_definition]
resource_definition = res_pb2.add()
resource_definition.type = "nomenclature.linnaen.com/Species"
resource_definition.pattern.append("families/{family}/genera/{genus}/species/{species}")

# Pass down the resource-name-alias cli option
opts = Options.build("resource-name-alias=nomenclature.linnaen.com/Species:CustomSpecies")

api_schema = api.API.build([fdp], package="nomenclature.linneaen.v1", opts=opts)

# Trigger the property that evaluates the CommonResource
resource_msgs = api_schema.protos["nomenclature.proto"].resource_messages

# Verify that the resource exists with the overriden type
assert "nomenclature.linnaen.com/Species" in resource_msgs
assert resource_msgs["nomenclature.linnaen.com/Species"].resource_type == "CustomSpecies"
Loading