chore: add a post-submit check that regenerating doesn't change anything#16941
Open
jskeet wants to merge 1 commit intogoogleapis:mainfrom
Open
chore: add a post-submit check that regenerating doesn't change anything#16941jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet wants to merge 1 commit intogoogleapis:mainfrom
Conversation
This is a post-submit as it takes a while (~25 minutes). We could *potentially* make it a pre-submit and only generate packages which have changed, but that would be more fiddly. It would be nice not to specify the protoc or pandoc version here, but that will require improvements in librarian (tracked in googleapis/librarian#5818). Fixes googleapis/librarian#4800
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
Author
|
Note: if we land googleapis/librarian#5860, the time may be significantly reduced. (It'll be hard to say by how much until it's in a released version of librarian, but it may end up taking less than 5 minutes.) At that point, we could consider making this a presubmit instead of a postsubmit check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a post-submit as it takes a while (~25 minutes). We could potentially make it a pre-submit and only generate packages which have changed, but that would be more fiddly.
It would be nice not to specify the protoc or pandoc version here, but that will require improvements in librarian (tracked in googleapis/librarian#5818).
Fixes googleapis/librarian#4800