chore(migration): Migrate code from googleapis/python-cloud-core into packages/google-cloud-core #15542

parthea · 2026-02-09T17:25:29Z

See #11000.

This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.

Closes #5750.

Closes #6390.

…6451) On Python 2.7, fall back to 'collections'. Closes #6450.

* blacken api_core and core

* remove iam module from core

* Release 0.29.0

* Release 0.29.1

Previously, the URLs would redirect using JavaScript, which would either be slow or not work at all (in case JavaScript is disabled on the browser)

* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide

* Add 'user_agent' and 'extra_headers' properties to 'Connection'. Deprecate the 'USER_AGENT' and '_EXTRA_HEADERS' class-level attributes. * Add 'client_info' parameter to 'Connection' ctor. * Implement 'Connection.user_agent' via its '_client_info'. * Ensure 'X-Goog-API-Client' header is always passed. * Create/use non-GAPIC-specific 'ClientInfo' class FBO HTTP/JSON clients. Derive the existing GAPIC class from it.

Needed for new 'client_info' support.

Also, pin grpcio < 2.0dev. Closes #5410.

…t.o. (#8207) * Prevent requests from hanging on SSL handshake issue by adding a max timeout of 5 minutes * rename and reuse constant * use named arg

… with type checkers (#8546)

* chore(python): update dependencies in .kokoro/docker/docs Source-Link: googleapis/synthtool@59171c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562 * Enable testing for Python 3.13 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

#312) * chore(python): Update the python version in docs presubmit to use 3.10 Source-Link: googleapis/synthtool@de3def6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5 * fix lint presubmit * fix lint build * fix lint build * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * exclude .github/workflows/lint.yml * fix lint build --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…fig (#314) Source-Link: googleapis/synthtool@106d292 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8ff1efe878e18bd82a0fb7b70bb86f77e7ab6901fed394440b6135db0ba8d84a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@bd9ede2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.4 to 3.1.5. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.4...3.1.5) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.26.3 to 20.26.6. - [Release notes](https://github.com/pypa/virtualenv/releases) - [Changelog](https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst) - [Commits](pypa/virtualenv@20.26.3...20.26.6) --- updated-dependencies: - dependency-name: virtualenv dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

* Feat: Client should pass client_options.api_key to auth library * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * bump auth requirement * bump api core requirement * bump requirements yet again * only enable feature if auth library has support * fix bare except lint issue * add skipped files * add skipped files again --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 2.4.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@93e1685 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

Source-Link: googleapis/synthtool@1fb7b51 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:58dd193e1be3f5f02276cdf222ed7f8dfc3be1f163488aea767bcf35a0e2b0cd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…talled (#329) Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

@chalmerlowe

* feat(ci): Add Python 3.14 support to owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat(ci): Add Python 3.14 support to core files * Apply suggestion from @chalmerlowe 3.7 is not supported in this repo. * Apply suggestion from @chalmerlowe * Apply suggestion from @chalmerlowe 3.7 is not supported in this repo. * fix(ci): Remove unit (3.7) from required checks * fix(coverage): Remove obsolete Python < 3.8 import logic * fix(coverage): Add no cover pragma for api_key import * fix(ci): Correct lint errors and coverage pragma case --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This PR onboards `google-cloud-core` to librarian. Blocked on googleapis/python-cloud-core#330 Fixes googleapis/librarian#2453 🦕 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Similar to googleapis/python-api-core#870

Automated: Migrate {target_path} from gsutil to gcloud storage This CL is part of the on going effort to migrate from the legacy `gsutil` tool to the new and improved `gcloud storage` command-line interface. `gcloud storage` is the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with other `gcloud` components. 🚀 ### Automation Details This change was **generated automatically** by an agent that targets users of `gsutil`. The transformations applied are based on the [gsutil to gcloud storage migration guide](http://go/gsutil-gcloud-storage-migration-guide). ### ⚠️ Action Required: Please Review and Test Carefully While we have based the automation on the migration guide, every use case is unique. **It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.** Be aware of potential differences between `gsutil` and `gcloud storage` that could impact your workflows. For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the `gcloud storage rsync` command has a different file deletion logic than `gsutil rsync`, which could lead to unintended file deletions. Our migration guides can help guide you through a list of mappings and some notable differences between the two tools. Standard presubmit tests are run as part of this CL's workflow. **If you need to target an additional test workflow or require assistance with testing, please let us know.** Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production. ### Support and Collaboration The `GCS CLI` team is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out. We are happy to work with you to test and adjust these changes as needed. **Contact:** `gcs-cli-hyd@google.com` We appreciate your partnership in this important migration effort! #gsutil-migration

…n' into migration.python-cloud-core.migration.2026-02-09_17-15-38.migrate

gemini-code-assist · 2026-02-09T17:26:18Z

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes a significant architectural change by migrating the google-cloud-core Python library into a dedicated packages/google-cloud-core directory. This move centralizes the library's components, including its core logic, testing infrastructure, and comprehensive documentation, under a new, standardized package structure. The migration ensures that the library's full development history is maintained, and the underlying migration tooling has been improved to handle complex repository structures like those involving submodules, thereby enhancing the overall integrity and future maintainability of the codebase.

Highlights

Codebase Migration: The entire google-cloud-core library, including its source code, documentation, and configuration files, has been migrated into a new packages/google-cloud-core subdirectory within the repository.
Configuration and Tooling Setup: New configuration files for development tools such as .coveragerc, .flake8, mypy.ini, noxfile.py, pytest.ini, and setup.py have been added to establish proper linting, testing, and build processes for the newly structured package.
Git History Preservation: The pull request explicitly requests a merge-commit to ensure that the complete git history of the google-cloud-core library is preserved during this migration, which is critical for maintaining an accurate record of changes.
Migration Script Enhancements: The single-library.git-migrate-history.sh script, used for the migration, was updated to include --recurse-submodules during cloning and to remove .git directories from submodules within the tree-filter step, making the migration process more robust for repositories with submodules.

Changelog

packages/google-cloud-core/.coveragerc
- Added a new coverage configuration file, specifying branch coverage, omission patterns for temporary files and __init__.py files, and exclusion rules for NO COVER pragmas, __repr__ methods, and NotImplementedError.
packages/google-cloud-core/.flake8
- Introduced a flake8 configuration file to enforce code style, including Google-style import order and ignoring specific linting errors like E203, E266, E501, W503, and I202.
packages/google-cloud-core/CHANGELOG.md
- The complete historical changelog for google-cloud-core has been added, detailing releases from version 2.5.0 down to 0.28.0, encompassing features, bug fixes, documentation updates, and breaking changes.
packages/google-cloud-core/google/cloud/_helpers/init.py
- Added the core helper utilities module, which includes functions for datetime conversions, protobuf handling, and gRPC channel/stub creation, along with internal helper classes like _LocalStack.
packages/google-cloud-core/scripts/split_repo_migration/single-library.git-migrate-history.sh
- Modified the migration script to use git clone --recurse-submodules and to incorporate git submodule update --init --recursive; find . -mindepth 2 -name .git -exec rm -rf {} +; within the tree-filter to correctly handle and clean up submodules during the history migration process.

Activity

No human activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request migrates the python-cloud-core library into this repository. The changes are extensive, involving the addition of the library's source code, tests, documentation, and various configuration files for CI/CD and development tooling. My review focused on the overall structure and correctness of the newly added files. The migration appears to be well-executed. I've added a couple of suggestions for minor improvements regarding mypy configuration and a security best practice in a utility script.

gemini-code-assist · 2026-02-09T17:30:39Z

packages/google-cloud-core/mypy.ini

@@ -0,0 +1,7 @@
+[mypy]
+python_version = 3.6


The python_version is set to 3.6, which is inconsistent with setup.py that requires Python >=3.7. To ensure mypy performs checks against the correct minimum supported version, update this to 3.7.

python_version = 3.7

gemini-code-assist · 2026-02-09T17:30:39Z

packages/google-cloud-core/scripts/readme-gen/readme_gen.py

+    jinja_env.globals["get_help"] = get_help
+
+    with io.open(source, "r") as f:
+        config = yaml.load(f)


The use of yaml.load() is unsafe and can lead to arbitrary code execution if processing untrusted YAML data. It is strongly recommended to use yaml.safe_load() instead. Although this script is used internally, adhering to security best practices is important for overall code health.

Suggested change

config = yaml.load(f)

config = yaml.safe_load(f)

tseaver and others added 30 commits August 6, 2018 14:48

Fix '_time_from_iso8601_time_naive' for values with micros. (#5756)

559f774

Closes #5750.

Nox: use inplace installs (#5865)

b3135f7

Use new Nox (#6175)

6a27a76

Add / fix badges for PyPI / versions. (#6158)

5dfad9d

Bump minimum 'api_core' version for all GAPIC libs to 1.4.1. (#6391)

61fbea2

Closes #6390.

Import stdlib ABCs from 'collections.abc' rather than 'collections'. (#…

3ba19ac

…6451) On Python 2.7, fall back to 'collections'. Closes #6450.

blacken api_core and core (#6668)

b611ca6

* blacken api_core and core

remove iam module from core (#6775)

1c6afc8

* remove iam module from core

Release core 0.29.0 (#6834)

852410c

* Release 0.29.0

Document Python 2 deprecation (#6910)

ba6314d

Release core 0.29.1 (#6942)

97a3d90

* Release 0.29.1

Updated client library documentation URLs. (#7307)

6f431bb

Previously, the URLs would redirect using JavaScript, which would either be slow or not work at all (in case JavaScript is disabled on the browser)

Remove classifier for Python 3.4 for end-of-life. (#7535)

e7803a9

* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide

Update dep on 'api_core' >= 1.11.0. (#7986)

0ff6076

Needed for new 'client_info' support.

Release core-1.0.0 (#7990)

7d23138

Core: Classify 503 Service Unavailable errors as transient. (#8182)

93d345a

Also, pin grpcio < 2.0dev. Closes #5410.

Release google-cloud-core 1.0.1 (#8184)

4be8b1f

Prevent requests from hanging on SSL handshake issue by adding a max …

cd82867

…t.o. (#8207) * Prevent requests from hanging on SSL handshake issue by adding a max timeout of 5 minutes * rename and reuse constant * use named arg

Release 1.0.2 (#8289)

23b490c

All: Add docs job to publish to googleapis.dev. (#8464)

fc10d08

Add nox session 'docs' to remaining manual clients. (#8478)

baca05f

Fixes #8545 by removing typing information for kwargs to not conflict…

6efbaec

… with type checkers (#8546)

Add compatibility check badges to READMEs. (#8288)

0299e6f

Bump minimum version for google-api-core to 1.14.0. (#8709)

7706494

Link to googleapis.dev documentation in READMEs. (#8705)

d60cb83

Linkify the PR in the change log. (#8790)

f69ad9a

Change build_api_url to an instance method. (#8747)

f899b62

Release core 1.0.3 (#8800)

acdbd70

Update intersphinx mapping for requests. (#8805)

736bd88

gcf-owl-bot bot and others added 27 commits November 15, 2024 16:06

chore(deps): update all dependencies (#317)

5e30aad

Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

chore(deps): update all dependencies (#318)

4a2598a

fix: Declare support for Python 3.13 (#326)

68db541

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

chore: remove unused files (#328)

0e05a27

chore(main): release 2.4.3 (#327)

a57cefb

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix: resolve issue where pre-release versions of dependencies are ins…

3eaed7e

…talled (#329) Co-authored-by: Victor Chudnovsky <vchudnov@google.com>

fix: remove setup.cfg configuration for creating universal wheels (#332)

2d915b7

chore(main): release 2.5.0 (#330)

2870aed

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chore(librarian): onboard to librarian (#336)

acd285e

This PR onboards `google-cloud-core` to librarian. Blocked on googleapis/python-cloud-core#330 Fixes googleapis/librarian#2453 🦕 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>

tests: update default python runtime for tests to 3.14 (#340)

8bc612a

Similar to googleapis/python-api-core#870

Merge remote-tracking branch 'remote.googleapis/python-cloud-core/mai…

8f13b24

…n' into migration.python-cloud-core.migration.2026-02-09_17-15-38.migrate

Trigger owlbot post-processor

22b579d

build: google-cloud-core migration: adjust owlbot-related files

4502d28

gemini-code-assist bot reviewed Feb 9, 2026

View reviewed changes

parthea self-assigned this Feb 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(migration): Migrate code from googleapis/python-cloud-core into packages/google-cloud-core #15542

chore(migration): Migrate code from googleapis/python-cloud-core into packages/google-cloud-core #15542

Uh oh!

parthea commented Feb 9, 2026

Uh oh!

gemini-code-assist bot commented Feb 9, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Uh oh!

gemini-code-assist bot Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

chore(migration): Migrate code from googleapis/python-cloud-core into packages/google-cloud-core #15542

Are you sure you want to change the base?

chore(migration): Migrate code from googleapis/python-cloud-core into packages/google-cloud-core #15542

Uh oh!

Conversation

parthea commented Feb 9, 2026

Uh oh!

gemini-code-assist bot commented Feb 9, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants