Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-apps-card/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ def prerelease_deps(session, protobuf_implementation):
session.skip("cpp implementation is not supported in python 3.11+")

# Install all dependencies
session.install("-e", ".")
session.install("-e", ".", "--no-deps")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the addition of --no-deps, the comment on the preceding line (# Install all dependencies) has become misleading. To improve code clarity and maintainability, please update the comment to accurately describe this step. For example: # Install the package itself, without dependencies.


# Install dependencies for the unit test environment
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ def test_create_read_session(mock_transport, client_under_test):
# validate test assumptions
assert client_under_test._transport is mock_transport

assert True

rpc_callable = mock.Mock()
mock_transport._wrapped_methods[mock_transport.create_read_session] = rpc_callable
table = "projects/{}/datasets/{}/tables/{}".format(
Expand Down
Loading