-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: librarian generate pull request: 20251224T091257Z #14989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated update generated by the Librarian CLI, integrating the latest proto changes across several Google Cloud client libraries. It primarily introduces new features, expands existing APIs with additional fields and messages, and refines documentation for services like AI Generative Language, Artifact Registry, Memorystore, Gemini Data Analytics, Google Chat, reCAPTCHA Enterprise, Dialogflow, and AlloyDB. The update ensures that the client libraries reflect the most recent service definitions and capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by the Librarian CLI, updates various Google Cloud client libraries based on recent proto changes. The updates include new features, documentation improvements, and other generated code modifications. My review focused on the clarity and correctness of the generated code and docstrings. I've identified a minor documentation issue in the Dialogflow CX library where a docstring could be improved for better clarity.
| default settings. Read-only field for the API | ||
| proto only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "Read-only field for the API proto only" is confusing for a public-facing docstring and appears to be an internal note. Since the field is marked as IMMUTABLE in the underlying proto, it can be set on creation but not on update. The documentation should clearly reflect this behavior for library users. Removing this sentence would improve clarity.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add Fingerprint to Artifact Registry Version resource
PiperOrigin-RevId: 846851972
Library-IDs: google-cloud-artifact-registry
Source-link: googleapis/googleapis@347b0e45
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update the description of ExportArtifact
PiperOrigin-RevId: 846851972
Library-IDs: google-cloud-artifact-registry
Source-link: googleapis/googleapis@347b0e45
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add support for RetrievalConfig
PiperOrigin-RevId: 846118142
Library-IDs: google-ai-generativelanguage
Source-link: googleapis/googleapis@bc7e3baa
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add support for GoogleMaps and FileSearch tools
PiperOrigin-RevId: 846118142
Library-IDs: google-ai-generativelanguage
Source-link: googleapis/googleapis@bc7e3baa
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add support for GroundingMetadata.google_maps_widget_context_token
PiperOrigin-RevId: 846116816
Library-IDs: google-ai-generativelanguage
Source-link: googleapis/googleapis@c631c694
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add json_name for GenerationConfig.response_json_schema_ordered field
PiperOrigin-RevId: 846116816
Library-IDs: google-ai-generativelanguage
Source-link: googleapis/googleapis@c631c694
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add IMAGE_RECITATION reason when generation is stopped due to recitation
PiperOrigin-RevId: 846116816
Library-IDs: google-ai-generativelanguage
Source-link: googleapis/googleapis@c631c694
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add POSTGRES_18 to DatabaseVersion
PiperOrigin-RevId: 845801340
Library-IDs: google-cloud-alloydb
Source-link: googleapis/googleapis@59fdfa7a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add LookerGoldenQuery to Context
PiperOrigin-RevId: 845792138
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@80509f2e
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: Correctly escape comment in DefaultServiceAccount
PiperOrigin-RevId: 845430981
Library-IDs: google-cloud-build
Source-link: googleapis/googleapis@ba1f5de3
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add accessory widget support for private messages
PiperOrigin-RevId: 845227338
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@1a9d00be
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add app authorization support to space APIs
PiperOrigin-RevId: 845227338
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@1a9d00be
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Improve documentation of attachment.proto, event_payload.proto and space.proto
PiperOrigin-RevId: 845227338
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@1a9d00be
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: specify the data sources supported only by the QueryData API
PiperOrigin-RevId: 845011245
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@4149dbdc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: specify the data sources supported only by the QueryData API
PiperOrigin-RevId: 845011156
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@884065f1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
last_backup_timeis added to message.google.cloud.memorystore.v1.BackupCollectionPiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
satisfies_pzsis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
Instance.simulate_maintenance_eventis added to message.google.cloud.memorystore.v1.PiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
total_backup_size_bytesis added to message.google.cloud.memorystore.v1.BackupCollectionPiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
maintenance_versionis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
encryption_infois added to message.google.cloud.memorystore.v1.BackupPiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
satisfies_pziis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
effective_maintenance_versionis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
EncryptionInfois addedPiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
discovery_endpointsin message.google.cloud.memorystore.v1.Instanceis changedPiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
kms_keyis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
available_maintenance_versionsis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
allow_fewer_zones_deploymentis added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
total_backup_countis added to message.google.cloud.memorystore.v1.BackupCollectionPiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
encryption_infois added to message.google.cloud.memorystore.v1.InstancePiperOrigin-RevId: 844938993
Library-IDs: google-cloud-memorystore
Source-link: googleapis/googleapis@b60f5a57
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Addition of GMAIL_MESSAGE value for RichLinkType enum in the RichLinkMetadata proto
PiperOrigin-RevId: 844825126
Library-IDs: google-apps-chat
Source-link: googleapis/googleapis@4eccddb5
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add LookerGoldenQuery to Context
PiperOrigin-RevId: 844667700
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@7ddafd82
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: clarify that WafFeature.EXPRESS is deprecated
PiperOrigin-RevId: 844437009
Library-IDs: google-cloud-recaptcha-enterprise
Source-link: googleapis/googleapis@23c58988
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add
phone_authentication_eventtoAnnotateAssessmentRequest. This new field allows you to indicate the phone number associated with a multi-factor authentication event, i.e.INITIATED_TWO_FACTOR,PASSED_TWO_FACTOR,FAILED_TWO_FACTORreasons, and the time of such an eventPiperOrigin-RevId: 844437009
Library-IDs: google-cloud-recaptcha-enterprise
Source-link: googleapis/googleapis@23c58988
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: document domain, package name and bundle id limits and validation
PiperOrigin-RevId: 844437009
Library-IDs: google-cloud-recaptcha-enterprise
Source-link: googleapis/googleapis@23c58988
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add risk reasons to FraudPreventionAssessment
PiperOrigin-RevId: 844437009
Library-IDs: google-cloud-recaptcha-enterprise
Source-link: googleapis/googleapis@23c58988
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a POLICY_BASED_CHALLENGE IntegrationType and associated settings
PiperOrigin-RevId: 844437009
Library-IDs: google-cloud-recaptcha-enterprise
Source-link: googleapis/googleapis@23c58988
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add verifiedBots field to RiskAnalysis and definitions for a Bot object to store metadata for a detected bot
PiperOrigin-RevId: 844437009
Library-IDs: google-cloud-recaptcha-enterprise
Source-link: googleapis/googleapis@23c58988
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: updated v2beta1 dialogflow client libraries
PiperOrigin-RevId: 843755897
Library-IDs: google-cloud-dialogflow
Source-link: googleapis/googleapis@55ab9c62
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: updated v3beta1 dialogflow client libraries
PiperOrigin-RevId: 843704214
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@3784b368
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: updated v2 dialogflow client libraries
PiperOrigin-RevId: 843703774
Library-IDs: google-cloud-dialogflow
Source-link: googleapis/googleapis@7a595fde
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a new data sources for QueryData API
PiperOrigin-RevId: 843338117
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@05f65958
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
SpannerReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
AlloyDbReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
QueryDataResponseis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
CloudSqlReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
CloudSqlDatabaseReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
AlloyDbDatabaseReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a QueryData API for NL2SQL conversion
PiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new method
QueryDatais added to serviceDataChatServicePiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
SpannerDatabaseReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
QueryDataRequestis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
QueryDataContextis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
cloud_sql_referenceis added to message.google.cloud.geminidataanalytics.v1beta.DatasourceReferencesPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
cloud_sql_referenceis added to message.google.cloud.geminidataanalytics.v1beta.DatasourcePiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ExecutedQueryResultis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
alloydbis added to message.google.cloud.geminidataanalytics.v1beta.DatasourceReferencesPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
GenerationOptionsis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
alloy_db_referenceis added to message.google.cloud.geminidataanalytics.v1beta.DatasourcePiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
spanner_referenceis added to message.google.cloud.geminidataanalytics.v1beta.DatasourcePiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
AgentContextReferenceis addedPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
spanner_referenceis added to message.google.cloud.geminidataanalytics.v1beta.DatasourceReferencesPiperOrigin-RevId: 842905100
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b32495a7
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: add messages stating that Data Catalog actions are deprecated
PiperOrigin-RevId: 842872738
Library-IDs: google-cloud-dlp
Source-link: googleapis/googleapis@dba08635
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: add example resource name to VertexDatasetResourceReference
PiperOrigin-RevId: 842872738
Library-IDs: google-cloud-dlp
Source-link: googleapis/googleapis@dba08635
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: remove duplicate gRPC service config file
PiperOrigin-RevId: 842752391
Library-IDs: google-cloud-artifact-registry
Source-link: googleapis/googleapis@b81889fe
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@effe5c4f
(exclusive) and
googleapis/googleapis@347b0e45
(inclusive).
Librarian Version: v0.0.0-20251120153138-6e4de1e6ca60
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
Generation failed for