Skip to content

fix(Spanner): ensure tag is passed to CommitRequest #8935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bshaffer wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

fix(Spanner): ensure tag is passed to CommitRequest #8935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Spanner/src/Transaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,12 +444,14 @@ public function commit(array $options = []): Timestamp
'requestOptions' => $this->requestOptions,
'transactionOptions' => $this->transactionOptions,
'singleUse' => $this->transactionSelector['singleUse'] ?? null,
'tag' => $this->tag ?? null,
]);
if (!empty($mutations)) {
// Set the mutation key if we have mutations but do not have a precommit token
$mutationKey = $mutations[array_rand($mutations)];
$operationTransactionOptions['mutationKey'] = $mutationKey;
}

// Execute the beginTransaction RPC.
$transaction = $this->operation->transaction($this->session, $operationTransactionOptions);
// Set the transaction ID of the current transaction.
Expand Down
Loading