-
Notifications
You must be signed in to change notification settings - Fork 451
docs: fix all README samples, rename command #8536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We are going to save this for next week when we roll out version 1.20 of the gapic generator (see googleapis/gapic-generator-php#768), because that will also update the docs for every single client library. |
Hectorhammett
previously approved these changes
Sep 15, 2025
Collaborator
|
This looked good to me but we need to re review after we see all the updates from the generator. Waiting on that update. |
Hectorhammett
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
next release
PRs to be included in the next release
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2sample will be used before aV1sample)### Sampledoesn't exist in the README, inserts the sample above### Debugginginstead. This will add samples for many READMEs which previously were being skipped because they didn't contain a### Sampleheaderusefrom import statements.