Skip to content

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Aug 22, 2025

  • Ensures most recent version is used (e.g. a V2 sample will be used before a V1 sample)
  • When ### Sample doesn't exist in the README, inserts the sample above ### Debugging instead. This will add samples for many READMEs which previously were being skipped because they didn't contain a ### Sample header
  • Fixes the bug where all README samples were missing use from import statements.
  • Updates ALL README SAMPLES with these fixes

@bshaffer bshaffer requested review from a team as code owners August 22, 2025 21:00
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 22, 2025
@bshaffer bshaffer changed the title docs: fix all samples, rename command docs: fix all README samples, rename command Aug 22, 2025
@bshaffer bshaffer added the next release PRs to be included in the next release label Aug 26, 2025
@bshaffer bshaffer removed the next release PRs to be included in the next release label Sep 4, 2025
@bshaffer
Copy link
Contributor Author

bshaffer commented Sep 4, 2025

We are going to save this for next week when we roll out version 1.20 of the gapic generator (see googleapis/gapic-generator-php#768), because that will also update the docs for every single client library.

Hectorhammett
Hectorhammett previously approved these changes Sep 15, 2025
@Hectorhammett Hectorhammett self-requested a review September 15, 2025 21:13
@Hectorhammett
Copy link
Collaborator

This looked good to me but we need to re review after we see all the updates from the generator. Waiting on that update.

@bshaffer bshaffer added the next release PRs to be included in the next release label Oct 6, 2025
@Hectorhammett Hectorhammett merged commit 121678e into main Oct 6, 2025
36 of 37 checks passed
@Hectorhammett Hectorhammett deleted the fix-add-sample-to-readme branch October 6, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release PRs to be included in the next release samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants