Skip to content

feat!: update minimum Node version to Node.js 18#8282

Open
gameroman wants to merge 2 commits into
googleapis:mainfrom
gameroman:node-minimum-18
Open

feat!: update minimum Node version to Node.js 18#8282
gameroman wants to merge 2 commits into
googleapis:mainfrom
gameroman:node-minimum-18

Conversation

@gameroman
Copy link
Copy Markdown

@gameroman gameroman commented May 14, 2026

This is a breaking change that will require new major versions

@gameroman gameroman requested review from a team as code owners May 14, 2026 08:02
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum Node.js version requirement to >=18 across several package.json files. The reviewer recommended using the full semantic version format (e.g., '18.0.0') instead of the shorthand '18' in certain files to maintain consistency with the rest of the repository.

Comment thread .github/scripts/package.json Outdated
Comment thread core/packages/logging-utils/samples/package.json Outdated
Comment thread handwritten/storage/package.json Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant