Skip to content

chore: upgrade libraries to ESLint v10 #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shivanee-p wants to merge 6 commits into from
Closed

chore: upgrade libraries to ESLint v10 #8267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8fbe802
build: upgrade core dependencies and handwritten libraries to ESLint …
shivanee-p May 13, 2026
8c5079d
build: extend gts base config in flat configs and remove redundant ig…
shivanee-p May 13, 2026
5c39d79
fix(generator): inline Prettier configuration and declare gts runtime…
shivanee-p May 14, 2026
58e6d51
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 14, 2026
8b51942
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 14, 2026
9308eef
build: pin ESLint version to 10.0.0 and add package overrides to prev…
shivanee-p May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/generator/gapic-generator-typescript/.prettierrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
// limitations under the License.

module.exports = {
...require('gts/.prettierrc.json')
}
bracketSpacing: false,
singleQuote: true,
trailingComma: 'all',
arrowParens: 'avoid',
};


1 change: 1 addition & 0 deletions core/generator/gapic-generator-typescript/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ npm_runtime_dependencies = [
"//:node_modules/yargs",
"//:node_modules/google-gax",
"//:node_modules/prettier",
"//:node_modules/gts",
]

npm_test_dependencies = npm_runtime_dependencies + [
Expand Down
9 changes: 9 additions & 0 deletions core/generator/gapic-generator-typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,14 @@
},
"engines": {
"node": ">=18"
},
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/bigquery-storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"protobufjs": "^7.5.5"
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/bigquery": "^8.0.0",
"@types/extend": "^3.0.4",
"@types/mocha": "^10.0.10",
Expand Down Expand Up @@ -74,5 +75,14 @@
"engines": {
"node": ">=18"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigquery-storage"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigquery-storage",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
10 changes: 9 additions & 1 deletion handwritten/bigquery/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,16 @@
"extend": "^3.0.2",
"stream-events": "^1.0.5"
},
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0",
"@sinonjs/fake-timers": "15.1.1",
"@google-cloud/common": {
"google-auth-library": "10.3.0"
}
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/storage": "^7.16.0",
"@types/big.js": "^6.2.2",
"@types/duplexify": "^3.6.4",
Expand Down Expand Up @@ -97,5 +100,10 @@
"sinon": "21.0.3",
"typescript": "^5.8.2"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigquery"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigquery",
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/bigtable/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
"stream-events": "^1.0.5"
},
"devDependencies": {
"eslint": "10.0.0",
"@grpc/grpc-js": "^1.13.2",
"@grpc/proto-loader": "^0.7.13",
"@types/escape-string-regexp": "^2.0.3",
Expand Down Expand Up @@ -116,5 +117,14 @@
"engines": {
"node": ">=18"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigtable"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/bigtable",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/cloud-profiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"teeny-request": "^9.0.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@types/extend": "^3.0.0",
"@types/long": "^5.0.0",
"@types/mocha": "^9.0.0",
Expand Down Expand Up @@ -86,5 +87,14 @@
"engines": {
"node": ">=14.0.0"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/cloud-profiler"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/cloud-profiler",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/datastore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"stream-events": "^1.0.5"
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/storage": "^7.16.0",
"@types/extend": "^3.0.4",
"@types/is": "^0.0.25",
Expand Down Expand Up @@ -88,5 +89,14 @@
"engines": {
"node": ">=18"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/datastore"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/datastore",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
4 changes: 4 additions & 0 deletions handwritten/error-reporting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"console-log-level": "^1.4.1"
},
"devDependencies": {
"eslint": "10.0.0",
"@compodoc/compodoc": "1.1.25",
"@hapi/hapi": "^21.4.4",
"@types/boom": "^7.3.5",
Expand Down Expand Up @@ -70,13 +71,16 @@
"typescript": "^5.9.3",
"uuid": "^8.3.2"
},
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0",
"undici": "5.28.4",
"tablesort": "5.6.0",
"cheerio": "1.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0",
"tablesort": "5.6.0",
"cheerio": "1.0.0"
}
Expand Down
21 changes: 21 additions & 0 deletions handwritten/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { FlatCompat } from '@eslint/eslintrc';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

const compat = new FlatCompat({
baseDirectory: __dirname,
});

export default [
Comment thread
shivanee-p marked this conversation as resolved.
...compat.extends('gts'),
{
ignores: [
"**/build/**",
"**/coverage/**",
"**/.nyc_output/**"
]
}
];
10 changes: 9 additions & 1 deletion handwritten/firestore/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"protobufjs": "^7.5.3"
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/cloud-rad": "^0.4.10",
"@google-cloud/opentelemetry-cloud-trace-exporter": "^3.0.0",
"@google-cloud/promisify": "^5.0.0",
Expand Down Expand Up @@ -122,7 +123,9 @@
"typescript": "^5.9.2"
},
"//_comment": "TODO: Remove @sinonjs/fake-timers overrides/resolutions when version > 15.3.0 fixes the duplicate identifier 'withGlobal' issue.",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0",
"@sinonjs/fake-timers": "15.1.1"
},
"resolutions": {
Expand All @@ -140,5 +143,10 @@
"./package.json": "./package.json",
"./build/src/path": "./build/src/path.js"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/firestore"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/firestore",
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/logging-bunyan/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"google-auth-library": "^9.0.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/common": "^5.0.0",
"@types/bunyan": "^1.8.4",
"@types/express": "^4.16.0",
Expand Down Expand Up @@ -87,5 +88,14 @@
"peerDependencies": {
"bunyan": "*"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-bunyan"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-bunyan",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/logging-winston/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"winston-transport": "^4.9.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/common": "^6.0.0",
"@types/lodash.mapvalues": "^4.6.9",
"@types/mocha": "^10.0.10",
Expand All @@ -84,5 +85,14 @@
"peerDependencies": {
"winston": ">=3.2.1"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-winston"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging-winston",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/logging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"uuid": "^9.0.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@google-cloud/bigquery": "^7.0.0",
"@google-cloud/opentelemetry-cloud-trace-exporter": "^2.1.0",
"@google-cloud/pubsub": "^4.0.0",
Expand Down Expand Up @@ -113,5 +114,14 @@
"engines": {
"node": ">=14.0.0"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/logging",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
12 changes: 11 additions & 1 deletion handwritten/pubsub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"p-defer": "^3.0.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@grpc/proto-loader": "^0.8.0",
"@opentelemetry/sdk-trace-base": "^1.17.0",
"@types/duplexify": "^3.6.4",
Expand Down Expand Up @@ -111,5 +112,14 @@
"why-is-node-running": "^2.3.0",
"yargs": "^17.7.2"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/pubsub"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/pubsub",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
4 changes: 4 additions & 0 deletions handwritten/spanner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
"uuid": "^11.1.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@grpc/reflection": "^1.0.4",
"@opentelemetry/sdk-trace-base": "^2.0.0",
"@opentelemetry/sdk-trace-node": "^2.0.0",
Expand Down Expand Up @@ -145,12 +146,15 @@
"typescript": "^5.8.2",
"yargs": "^17.7.2"
},
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0",
"gcp-metadata": "^7.0.1",
"@sinonjs/fake-timers": "15.2.1"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0",
"gcp-metadata": "^7.0.1",
"@sinonjs/fake-timers": "15.2.1"
}
Expand Down
12 changes: 11 additions & 1 deletion handwritten/storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"uuid": "^8.0.0"
},
"devDependencies": {
"eslint": "10.0.0",
"@babel/cli": "^7.22.10",
"@babel/core": "^7.22.11",
"@google-cloud/pubsub": "^4.0.0",
Expand Down Expand Up @@ -133,5 +134,14 @@
"yargs": "^17.3.1",
"cross-env": "^7.0.3"
},
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/storage"
"homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/storage",
"//_comment_eslint": "Pin eslint version at 10.0.0 until we upgrade the node version",
"overrides": {
"eslint": "10.0.0"
},
"pnpm": {
"overrides": {
"eslint": "10.0.0"
}
}
}
Loading
Loading