-
Notifications
You must be signed in to change notification settings - Fork 674
test: run the bigtable system tests in google cloud build #8192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 44 commits into
main
from
migrate-bigtable-to-gcp-cloud-build
May 12, 2026
+82
−4
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
f14703f
Add cloudbuild.yaml
danieljbruce 248638f
Shorten the script
danieljbruce cdb2ad1
remove the timeout
danieljbruce 372a03b
feat: add new Bigtable feature
danieljbruce 7caf8a0
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
danieljbruce 55b0dec
Merge branch 'main' into migrate-bigtable-to-gcp-cloud-build
danieljbruce 7a3fadd
Merge branch 'main' into migrate-bigtable-to-gcp-cloud-build
danieljbruce 5f930f9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] f3772ea
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
gcf-owl-bot[bot] 83f73dd
feat: add new Bigtable feature
danieljbruce d7782b2
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
danieljbruce 6be7893
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1f71bd1
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
gcf-owl-bot[bot] e6cc411
Changed to `ubuntu` in the yaml file
danieljbruce c836303
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
danieljbruce 1ab42bc
change the dir to handwritten/bigtable
danieljbruce 8e6ff1d
Change the pre-system test script
danieljbruce 051f019
Fix the unique id error
danieljbruce 20b11db
Add pre system tests to the first step
danieljbruce a74e61e
Remove the comment changed to
danieljbruce 0aae31a
Eliminate the first pack and play error
danieljbruce af443d1
Fix `require` error with node dependencies
danieljbruce 57bbdad
Modify the pack and play tests by adding a header
danieljbruce f6d43fe
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 8dd7d70
Eliminate unnecessary comments
danieljbruce fd18c1a
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
danieljbruce bfe5155
Restore the system test script
danieljbruce e51a2e8
Increase the timeout to 3 hours for the system tes
danieljbruce 11f861b
Merge branch 'main' into migrate-bigtable-to-gcp-cloud-build
danieljbruce 88a19c7
Add dependency comment
danieljbruce c6a65a8
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
danieljbruce 83539cc
Do a conditional diff check
danieljbruce 9f6587c
check against main removed
danieljbruce 9916905
Add a comment about the packnplay tests
danieljbruce 3ce9c3f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 45420f8
pin the node version
danieljbruce 206070f
Apply suggestions from code review
danieljbruce 93476ce
Change all node runs to node 24
danieljbruce b8599b8
Fix the install script to use cjs
danieljbruce 34475c4
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 9fcae3c
Remove initial step for checking the diff
danieljbruce 11f52d2
Remove workspace check and presystem-test
danieljbruce ae907a5
Merge branch 'migrate-bigtable-to-gcp-cloud-build' of https://github.…
danieljbruce f786ec8
Merge branch 'main' of https://github.com/googleapis/google-cloud-nod…
danieljbruce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| steps: | ||
| # 1. Set up Node.js environment | ||
| - name: 'node:24' | ||
| entrypoint: 'bash' | ||
| args: | ||
| - '-c' | ||
| - | | ||
| npm install | ||
| dir: 'handwritten/bigtable' | ||
| id: 'install-dependencies' | ||
|
|
||
| # 2. Configure environment variables for the tests and run system tests | ||
| # - GOOGLE_APPLICATION_CREDENTIALS: GCB steps run as a service account | ||
| # that is typically granted permissions directly. Explicitly setting | ||
| # GOOGLE_APPLICATION_CREDENTIALS might not be needed if the GCB service | ||
| # account has the right roles (e.g., Bigtable Admin, Bigtable User). | ||
| # If you need to use specific service account key JSON, you'd store it | ||
| # in Secret Manager and mount it here. For simplicity, we'll rely on | ||
| # the GCB service account's inherent permissions. | ||
| # - GCLOUD_PROJECT: Can be passed as a build variable. | ||
| - name: 'node:24' | ||
| entrypoint: 'bash' | ||
| args: | ||
| - '-c' | ||
| - | | ||
| npm run system-test | ||
| dir: 'handwritten/bigtable' | ||
| env: | ||
| - 'GCLOUD_PROJECT=${_GCP_PROJECT_ID}' # Pass project ID via build variable | ||
| # If you need specific credentials from Secret Manager, uncomment these: | ||
| # - 'GOOGLE_APPLICATION_CREDENTIALS=/secrets/sa-key.json' | ||
| id: 'run-system-tests' | ||
| waitFor: ['install-dependencies'] | ||
| # For Secret Manager, uncomment these (adjust secret name and volume path as needed): | ||
| # secretEnv: ['SA_KEY'] | ||
| # volumes: | ||
| # - name: 'sa-keys' | ||
| # path: '/secrets' | ||
|
|
||
| # 3. (Optional) Code Coverage Reporting | ||
| - name: 'node:24' | ||
| entrypoint: 'bash' | ||
| args: | ||
| - '-c' | ||
| - | | ||
| # Check if nyc is installed and run report | ||
| if [ -f ./node_modules/nyc/bin/nyc.js ]; then | ||
| ./node_modules/nyc/bin/nyc.js report || true # `|| true` prevents build failure if nyc report itself exits non-zero | ||
| else | ||
| echo "nyc not found, skipping coverage report." | ||
| fi | ||
| # The original codecov.sh script from Kokoro needs to be made available to GCB. | ||
| # Options: | ||
| # a) Commit codecov.sh into your repo (e.g., .kokoro/codecov.sh) and call it: | ||
| # if [ -f .kokoro/codecov.sh ]; then . ./.kokoro/codecov.sh; fi | ||
| # b) Replicate its functionality directly in this step. | ||
| # c) Store it in a GCS bucket and fetch it. | ||
| echo "Codecov reporting (if desired) would be integrated here." | ||
| dir: 'handwritten/bigtable' | ||
| id: 'coverage-report' | ||
| waitFor: ['run-system-tests'] | ||
|
|
||
| # If you use Secret Manager for credentials, uncomment and configure: | ||
| # availableSecrets: | ||
| # secretManager: | ||
| # - versionName: projects/${PROJECT_ID}/secrets/YOUR_SERVICE_ACCOUNT_KEY_SECRET_NAME/versions/latest | ||
| # env: 'SA_KEY' # This env var will hold the secret value. Use it as GOOGLE_APPLICATION_CREDENTIALS in step 3 if needed. | ||
|
|
||
| # Define a substitution variable for your project ID | ||
| # Replace 'long-door-651' with the actual GCP Project ID your system tests should run against. | ||
| substitutions: | ||
| _GCP_PROJECT_ID: 'long-door-651' | ||
|
|
||
| timeout: '10800s' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this modifying a generated asset? Does this proto.js get made by the generator? If so, does it risk getting overwritten in the future? Would the library break if this happened?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. tabular-api-surface.ts is entirely handwritten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I meant "protos.js", not this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protos.js diff has been eliminated by merging with main.