feat: add periodic WARNING metrics to assist in debugging#12976
Open
agrawal-siddharth wants to merge 1 commit intogoogleapis:mainfrom
Open
feat: add periodic WARNING metrics to assist in debugging#12976agrawal-siddharth wants to merge 1 commit intogoogleapis:mainfrom
agrawal-siddharth wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a HealthCheckMetrics system within ConnectionWorker to monitor and log stream health, including latency, retry counts, and error responses. It also adds corresponding unit tests to verify metric gathering and threshold logic. The review feedback highlights several critical thread-safety concerns, recommending synchronization for metric updates and ensuring that shared state, such as the retry count and request queues, is accessed within existing locks to prevent race conditions. Additionally, there are suggestions to improve resource efficiency by caching the Gson instance and declaring constants as static final.
agrawal-siddharth
force-pushed
the
dump_warning
branch
2 times, most recently
from
f2bf77d to
4b9d050
Compare
agrawal-siddharth
force-pushed
the
dump_warning
branch
from
4b9d050 to
ac34cb6
Compare
GaoleMeng
reviewed
May 5, 2026
GaoleMeng
approved these changes
May 5, 2026
GaoleMeng
reviewed
May 5, 2026
agrawal-siddharth
force-pushed
the
dump_warning
branch
4 times, most recently
from
d7645b8 to
52b4b49
Compare
agrawal-siddharth
force-pushed
the
dump_warning
branch
from
52b4b49 to
6576384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.