feat(bigquery): added error attributes to span tracing#12115
Open
feat(bigquery): added error attributes to span tracing#12115
Conversation
…operty manipulation in tests
ldetmer
commented
Mar 19, 2026
...ry/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java
Show resolved
Hide resolved
… GoogleJsonResponseException
jinseopkim0
reviewed
Mar 19, 2026
...y/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/telemetry/ErrorTypeUtil.java
Outdated
Show resolved
Hide resolved
Comment on lines
+104
to
+105
| span.setAttribute( | ||
| BigQueryTelemetryTracer.STATUS_MESSAGE, errorResponse.getDetails().getMessage()); |
Contributor
There was a problem hiding this comment.
Per @westarle's comment in googleapis/java-bigquery#4126 (comment), I'm thinking we would need to document this in the enablement site, as this attribute is not part of OpenTelemetry semconv. What do you think?
Contributor
Author
There was a problem hiding this comment.
yes, thanks for pointing that out, let me look into how we do that and will update comment
jinseopkim0
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds capture of error attributes to BigQuery span tracing.
Example with GoogleJsonResponseException
Example with exception
see note here about exception.type mapping to error/name