-
Notifications
You must be signed in to change notification settings - Fork 448
fix(bigtable): always include app_profile_id in metadata params #16089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
elinorli
wants to merge
1
commit into
googleapis:main
Choose a base branch
from
elinorli:rls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
google/cloud/bigtable/internal/bigtable_metadata_decorator_test.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "google/cloud/bigtable/internal/bigtable_metadata_decorator.h" | ||
| #include "google/cloud/bigtable/testing/mock_bigtable_stub.h" | ||
| #include "google/cloud/testing_util/validate_metadata.h" | ||
| #include <gmock/gmock.h> | ||
| #include <memory> | ||
|
|
||
| namespace google { | ||
| namespace cloud { | ||
| namespace bigtable_internal { | ||
| GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN | ||
| namespace { | ||
|
|
||
| using ::google::cloud::bigtable::testing::MockBigtableStub; | ||
| using ::google::cloud::testing_util::ValidateMetadataFixture; | ||
| using ::testing::Contains; | ||
| using ::testing::Pair; | ||
|
|
||
| class BigtableMetadataTest : public ::testing::Test { | ||
| protected: | ||
| void SetUp() override { mock_ = std::make_shared<MockBigtableStub>(); } | ||
|
|
||
| std::multimap<std::string, std::string> GetMetadata( | ||
| grpc::ClientContext& client_context) { | ||
| return validate_metadata_fixture_.GetMetadata(client_context); | ||
| } | ||
|
|
||
| std::shared_ptr<MockBigtableStub> mock_; | ||
|
|
||
| private: | ||
| ValidateMetadataFixture validate_metadata_fixture_; | ||
| }; | ||
|
|
||
| TEST_F(BigtableMetadataTest, MutateRowAppProfileIdEmpty) { | ||
| EXPECT_CALL(*mock_, MutateRow) | ||
| .WillOnce(::testing::Return(google::bigtable::v2::MutateRowResponse{})); | ||
|
|
||
| BigtableMetadata stub(mock_, {}); | ||
| grpc::ClientContext context; | ||
| google::bigtable::v2::MutateRowRequest request; | ||
| request.set_table_name("projects/p/instances/i/tables/t"); | ||
|
|
||
| auto status = stub.MutateRow(context, Options{}, request); | ||
| auto metadata = GetMetadata(context); | ||
| EXPECT_THAT(metadata, Contains(Pair("x-goog-request-params", | ||
| "app_profile_id=&table_name=projects%2Fp%" | ||
| "2Finstances%2Fi%2Ftables%2Ft"))); | ||
| } | ||
|
|
||
| TEST_F(BigtableMetadataTest, MutateRowAppProfileIdNotEmpty) { | ||
| EXPECT_CALL(*mock_, MutateRow) | ||
| .WillOnce(::testing::Return(google::bigtable::v2::MutateRowResponse{})); | ||
|
|
||
| BigtableMetadata stub(mock_, {}); | ||
| grpc::ClientContext context; | ||
| google::bigtable::v2::MutateRowRequest request; | ||
| request.set_table_name("projects/p/instances/i/tables/t"); | ||
| request.set_app_profile_id("my-profile"); | ||
|
|
||
| auto status = stub.MutateRow(context, Options{}, request); | ||
| auto metadata = GetMetadata(context); | ||
| EXPECT_THAT(metadata, | ||
| Contains(Pair("x-goog-request-params", | ||
| "app_profile_id=my-profile&table_name=projects%2Fp%" | ||
| "2Finstances%2Fi%2Ftables%2Ft"))); | ||
| } | ||
|
|
||
| } // namespace | ||
| GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END | ||
| } // namespace bigtable_internal | ||
| } // namespace cloud | ||
| } // namespace google |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic to add
app_profile_idto theparamsvector is duplicated 17 times across this file. According to the repository style guide (lines 13-14), duplicated code appearing 3 or more times should be factored out into a helper function to improve maintainability and ensure consistency across all RPC methods.References