Skip to content

Comments

ci: update vcpkg url regex#15998

Open
scotthart wants to merge 1 commit intogoogleapis:mainfrom
scotthart:kokoro_windows_cmake_release
Open

ci: update vcpkg url regex#15998
scotthart wants to merge 1 commit intogoogleapis:mainfrom
scotthart:kokoro_windows_cmake_release

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 24, 2026

Escape the . characters in the date format.

This change is Reviewable

@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue in the CI script responsible for downloading vcpkg. By accurately escaping dots in the regular expression, it ensures that date-like vcpkg version tags are correctly parsed, thereby preventing potential build failures related to incorrect vcpkg archive URL generation.

Highlights

  • Vcpkg URL Regex Fix: Corrected the regular expression used to identify date-like vcpkg version tags in the CI script. The previous regex incorrectly treated dots as wildcards, which could lead to misidentification of version strings and incorrect URL construction.
Changelog
  • ci/kokoro/lib/vcpkg.sh
    • Fixed regex for vcpkg version matching to correctly interpret literal dots.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the regular expression used to identify date-like vcpkg versions. By escaping the literal dots in the regex, it ensures that the pattern accurately matches YYYY.MM.DD formats, preventing potential mismatches and ensuring the correct archive URL is constructed.

VCPKG_VERSION="$(<ci/etc/vcpkg-version.txt)"
url="https://github.com/microsoft/vcpkg/archive/${VCPKG_VERSION}.tar.gz"
if [[ "${VCPKG_VERSION}" =~ [0-9]{4}.[0-9]{2}.[0-9]{2} ]]; then
if [[ "${VCPKG_VERSION}" =~ [0-9]{4}\.[0-9]{2}\.[0-9]{2} ]]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change to escape the dots (.) in the regular expression is a crucial correctness fix. In regex, an unescaped dot acts as a wildcard matching any character, which could lead to unintended matches for VCPKG_VERSION strings that are not in the YYYY.MM.DD format. Escaping them with \. ensures that only literal dots are matched, making the version detection robust and accurate for constructing the correct download URL.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.63%. Comparing base (fea1ad9) to head (e114c6f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15998   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files        2334     2334           
  Lines      214635   214635           
=======================================
+ Hits       198831   198833    +2     
+ Misses      15804    15802    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart force-pushed the kokoro_windows_cmake_release branch from e114c6f to 37ffeae Compare February 24, 2026 18:13
@scotthart scotthart marked this pull request as ready for review February 24, 2026 19:29
@scotthart scotthart requested a review from a team as a code owner February 24, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant