-
Notifications
You must be signed in to change notification settings - Fork 346
fix: add types to default and verify_token and Request __init__ based on comments in the source code. #1588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wyattscarpenter
wants to merge
26
commits into
googleapis:main
Choose a base branch
from
wyattscarpenter:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
ae25f47
fix: add types to verify_token and request __init__
wyattscarpenter fef7572
Merge branch 'main' into patch-1
wyattscarpenter bfd3dee
type default based on comments
wyattscarpenter e93ddd1
Update _default.py: wait actually I do want it to be Noneable, that's…
wyattscarpenter 72e40a9
Update _default.py: it's probably better to use the more-supported sy…
wyattscarpenter 6ab82cd
Update _default.py: attempt to avoid circular import
wyattscarpenter f96c2a5
Merge branch 'main' into patch-1
chalmerlowe 64ae612
Merge branch 'main' into patch-1
chalmerlowe e867a0b
Merge branch 'main' into patch-1
chalmerlowe 5e7e3f5
Update google/auth/_default.py
chalmerlowe 45306de
Update google/auth/_default.py
chalmerlowe 2e6829e
Update google/auth/_default.py
chalmerlowe 448d752
Update google/auth/_default.py
chalmerlowe f4540e3
Update google/oauth2/id_token.py
chalmerlowe 0a99a32
Update google/oauth2/id_token.py
chalmerlowe ae81aff
Update google/oauth2/id_token.py
chalmerlowe be19889
Update google/auth/transport/requests.py
chalmerlowe 7bf82e8
Update google/auth/transport/requests.py
chalmerlowe 58d8a88
Update google/auth/transport/requests.py
chalmerlowe 958292a
Update google/auth/transport/requests.py
chalmerlowe fa336fd
Merge branch 'main' into patch-1
chalmerlowe 4be0692
Update _default.py
chalmerlowe 152bc0e
Update id_token.py
chalmerlowe f5ca5e4
Update _default.py
chalmerlowe 6d75ce2
Apply suggestion from @chalmerlowe
chalmerlowe 82f1422
Apply suggestion from @chalmerlowe
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually bad to return something with Any in it, but, um, that's just what was in the comment. ¯\_(ツ)_/¯
If the reviewer happens to have a better & more-accurate idea, let him change this line accordingly.