Skip to content

chor(storage): Restart & delete resumable upload part 2 #23376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dazuma merged 5 commits into from
Aug 1, 2025
Merged

chor(storage): Restart & delete resumable upload part 2 #23376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a5d44f
adding default value
shubhangi-google Jun 12, 2025
e7b7ae6
try
shubhangi-google Jun 13, 2025
7f8bc15
try
shubhangi-google Jun 13, 2025
7d9a55d
updating test
shubhangi-google Jun 16, 2025
c1ee93f
Merge branch 'main' into restart_delete_resumable_upload_v3
dazuma Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-apis-core/lib/google/apis/core/base_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def delete_resumable_upload(bucket, upload_id, options: nil)
command = make_storage_upload_command(:delete, 'b/{bucket}/o', options)
command.upload_id = upload_id
command.params['bucket'] = bucket unless bucket.nil?
command.delete_upload = options[:delete_upload] unless options[:delete_upload].nil?
command.delete_upload = true
execute_or_queue_command(command)
end

Expand Down
2 changes: 1 addition & 1 deletion google-apis-core/spec/google/apis/core/service_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@
service.send(
:delete_resumable_upload,
bucket_name, upload_id,
options: { upload_chunk_size: 11, delete_upload: true }
options: { upload_chunk_size: 11}
)
end

Expand Down
Loading