fix: Empty last chunk case in resumable upload that is not a stream#1802
Open
john0312 wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: Empty last chunk case in resumable upload that is not a stream#1802john0312 wants to merge 1 commit intogoogleapis:mainfrom
john0312 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Blessed4eva
approved these changes
Aug 18, 2022
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
salomankevin655-beep
approved these changes
Dec 11, 2025
vchudnov-g
reviewed
Dec 11, 2025
For an upload that inherits the MediaUpload class and is not a stream, if the size of the upload is exact multiples of the chunksize, the last chunk would be empty and the generated Content-Range header will result in "Bad Request". Details: "Failed to parse Content-Range header."
john0312
force-pushed
the
fix-empty-last-chunk
branch
from
1f7f160 to
328bea8
Compare
vchudnov-g
approved these changes
Apr 3, 2026
Contributor
vchudnov-g
left a comment
vchudnov-g
left a comment
There was a problem hiding this comment.
PTAL at my suggestion for clarity/code-deduping.
Otherwise, LGTM
| # sending "bytes 0--1/0" results in an invalid request | ||
| # Only add header "Content-Range" if chunk_end != -1 | ||
| if chunk_end != -1: | ||
| if chunk_end - self.resumable_progress + 1 == 0 and chunk_end != -1: |
Contributor
There was a problem hiding this comment.
I suggest assigning
content_length = chunk_end - self.resumable_progress + 1 == 0 and chunk_end
before the headers = ... line and using content_length both for the header and in this conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an upload that inherits the MediaUpload class and is not a stream,
if the size of the upload is exact multiples of the chunksize, the last
chunk would be empty and the generated Content-Range header will result
in "Bad Request". Details: "Failed to parse Content-Range header."
Fixes #1801 🦕