chore: prepare GAX for monorepo#663
Open
bshaffer wants to merge 10 commits into
Open
Conversation
bshaffer
force-pushed
the
prepare-for-monorepo
branch
from
68bd00d to
e80db5e
Compare
bshaffer
commented
Apr 15, 2026
Co-authored-by: Brent Shaffer <betterbrent@google.com>
…into prepare-for-monorepo
6 tasks
bshaffer
commented
May 20, 2026
| $deprecatedInterceptors = (new \ReflectionClass(Interceptor::class)) | ||
| ->getMethod('interceptUnaryUnary') | ||
| ->getParameters()[3] | ||
| ->getName() === 'metadata'; |
Contributor
Author
There was a problem hiding this comment.
Look at grpc version instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the changes in #663 here first (to keep track)
dev/build-protobuf-docs.sh- filed feature request (Addgoogle/protobufto reference documentation google-cloud-php#9118). This generates the API docs for protobuf, but should not be maintained by us, especially now that we are removing doctum support. When this needs to be generated, it should be done by the protobuf team, or by us using this script from git history. Additionally, we are deploying protocol buffers reference docs to Cloud RAD (see feat(docs): publish protobuf to refdocs google-cloud-php#9126), which may be able to replace the reference docs at protocolbuffers.github.iodev/sh/regenerate-test-protos.sh- These are test protos and do not need to be public. We should remove them fromsrcand put them intests(if we use them in testing) for GAX 2.0. This script should then be moved intotestsor removed entirely. Look into moving GAX tests offTestingprotos OR (as a feature request) add a bot which updates them.dev/sh/test-composer-conflict.sh- Tests that composer works as expected. Why are we testing that composer works? This one has to go!devdirectorygoogle/protobufto reference documentation google-cloud-php#9118)