-
Notifications
You must be signed in to change notification settings - Fork 78
chore: fix mypy issue for __func__ type
#2562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d1451da
13a7f12
24eb034
b5ee1b1
015bee0
b0f00cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not totally against this change. But if we could silence specific imports, that would probably be cleaner. Sometimes the errors can be solved by adding a |
||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I addressed this in this PR by configuring mypy to check the untyped defs. Maybe we should remove this silencing, and try to get that other PR iin instead? |
||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| [mypy] | ||
| python_version = 3.14 | ||
| namespace_packages = True | ||
|
|
||
| # FIX: Prevents failure when dependencies (like google-iam) lack type hints | ||
| ignore_missing_imports = True | ||
|
|
||
| # FIX: Silences the "note: By default the bodies of untyped functions are not checked" | ||
| # This keeps CI logs clean and focused on actual errors. | ||
| check_untyped_defs = False | ||
|
|
||
| # Helps mypy navigate the 'google' namespace more reliably in 3.10+ | ||
| explicit_package_bases = True | ||
|
|
||
| # Performance: reuse results from previous runs to speed up 'nox' | ||
| incremental = True |
Uh oh!
There was an error while loading. Please reload this page.