(fix): fix tests by addressing TypeScript type mismatches #2412
Open
ikuleshov wants to merge 2 commits into
Open
(fix): fix tests by addressing TypeScript type mismatches #2412ikuleshov wants to merge 2 commits into
ikuleshov wants to merge 2 commits into
Conversation
ikuleshov
force-pushed
the
fix/typescript-type-mismatches
branch
2 times, most recently
from
3cb60e7 to
4a750c6
Compare
- Replace enums with string literal union types for MetricAggregation, OperationType, and MatchType - Eliminate code duplication by using single mapping objects for options - Improve type safety for GA4 API request builder
ikuleshov
force-pushed
the
fix/typescript-type-mismatches
branch
from
4a750c6 to
9b66ba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace enums with string literal union types for MetricAggregation, OperationType, and MatchType