Fix the audio-visualizer-demo#288
Conversation
…e/audio-visualizer-demo
…werdev-a/xrblocks into feature/audio-visualizer-demo
|
Hi the owner behind Power Dev, Not to stop you from contributing! For all new demos, I would like it to demonstrate new interactive perception or XR-specific features. For audio, it could be visualizing sound for accessibility using icons & Gemini ;) simple audio visualization is trivial. Can you also attach an unlisted youtube video or a screenshot for new demos? === Also I would really like to collaborate with real human behind AI agents --- would you privately message me your contact information? You can find my email at the bottom of https://duruofei.com/ |
|
Specifically for audio visualization, it could be more creative that anchors to real-world objects, or be more aesthetics like Solines. The current demo looks too simple like created by https://xrblocks.github.io/gem without too much deeper thought :) |
|
|
||
| this._isListening = true; | ||
| this._setStatus('● Listening'); | ||
| this._micButton.setText?.('stop'); |
There was a problem hiding this comment.
do we need the optional chaining on each of these set texts?
There was a problem hiding this comment.
We haven't update the legacy UI since this year. Latest UI reference was using uikit with sample here: https://xrblocks.github.io/docs/samples/UIBlocks/
However, for most demos, UI isn't important so legacy UI provides a quick SDF solution for quick demo.
| this._analyser = null; | ||
| this._isListening = false; | ||
| this._setStatus('Stopped'); | ||
| this._micButton.setText?.('mic'); |
There was a problem hiding this comment.
again, not sure we need optional chaining here
There was a problem hiding this comment.
you may keep it as it is :)
ruofeidu
added
the
demo
… and draggable pannel
…e/audio-visualizer-demo
…e/audio-visualizer-demo
|
Lint and Format Check is broken, please run: |
3 participants
No description provided.