[DSLX Fuzz testing] Refactor ValidateFuzzTestDomain to always evaluate domain expressions to InterpValue using ConstexprEvaluator. Restores early type safety by recursively validating constexpr-evaluated domain values against struct parameter types.#4333
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[DSLX Fuzz testing] Refactor ValidateFuzzTestDomain to always evaluate domain expressions to InterpValue using ConstexprEvaluator. Restores early type safety by recursively validating constexpr-evaluated domain values against struct parameter types.#4333copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…e domain expressions to InterpValue using ConstexprEvaluator. Restores early type safety by recursively validating constexpr-evaluated domain values against struct parameter types. Support StructType in ValidateFuzzTestDomainValue by recursively validating elements against struct members. Fix a bug where empty tuple domains `()` (which represent Arbitrary) were incorrectly rejected as "implies a tuple type, but parameter is not a tuple". Empty tuples are now allowed as arbitrary domains for any parameter type. PiperOrigin-RevId: 922314923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DSLX Fuzz testing] Refactor ValidateFuzzTestDomain to always evaluate domain expressions to InterpValue using ConstexprEvaluator. Restores early type safety by recursively validating constexpr-evaluated domain values against struct parameter types.
Support StructType in ValidateFuzzTestDomainValue by recursively validating elements against struct members.
Fix a bug where empty tuple domains
()(which represent Arbitrary) were incorrectly rejected as "implies a tuple type, but parameter is not a tuple". Empty tuples are now allowed as arbitrary domains for any parameter type.