Prevent parameter names of top functions from being changed during ir conversion.#3889
Open
meheff wants to merge 2 commits intogoogle:mainfrom
Open
Prevent parameter names of top functions from being changed during ir conversion.#3889meheff wants to merge 2 commits intogoogle:mainfrom
meheff wants to merge 2 commits intogoogle:mainfrom
Conversation
The parameter names of top functions become part of the exposed interface in the generated code. These names need to be preserved. This change raises an error if the legalized name during IR conversion differs from the original name.
meheff
changed the title
`block` is an IR keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter names of top functions become part of the exposed interface in the generated code. These names need to be preserved. This change raises an error if the legalized name during IR conversion differs from the original name.
A potentially more flexible change would be allow keywords as identifiers, but that is pretty invasive and I don't know if there are hidden problems here. This change at lease prevents silently renaming the visible interface of functions/modules.