Add IR conversion feedback to the DSLX interpreter#3882
Open
magancarz wants to merge 1 commit intogoogle:mainfrom
Open
Add IR conversion feedback to the DSLX interpreter#3882magancarz wants to merge 1 commit intogoogle:mainfrom
magancarz wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
|
FYI @richmckeever |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an IR conversion test to the DSLX interpreter enabled by
lower_to_irflag which is set by default. It performs the IR conversion check on every non-parametric proc or function and returns error if any fails. Tests can also be included in the check by addingconvert_testsflag.