Open
Conversation
stepancheg
force-pushed
the
future-for-dispatch
branch
from
4fbd5aa to
2b4f63b
Compare
stepancheg
force-pushed
the
future-for-dispatch
branch
from
2b4f63b to
728d8af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove field
terminal_error.If I understand this code correctly,
terminal_errorfield is used only betweenrunreturned with error and immediately after on the next iteration of the loop before exiting the future: locally to the futurepoll.The context is this:
terminal_erroronly works for inflight requests, but this is not enough to provide good diagnostics if we are sending request to a dispatch which has already failed.Instead, there can be a field like
Arc<OnceCell<SomeError>>shared between dispatch and channel, so that if writing to channel or reading back from oneshot channel fails, we could attach that error as error source.So I start by cleaning up existing code.