D-tale query method code injection#150
Open
VickyTheViking wants to merge 3 commits intogoogle:mainfrom
Open
Conversation
VickyTheViking
changed the title
Contributor
|
Hello @VickyTheViking, thank you for your contribution! |
Contributor
giacomo-doyensec
left a comment
giacomo-doyensec
left a comment
There was a problem hiding this comment.
I left some additional comments and suggestions, feel free to reach out for any doubt or question!
dtale/exposed_ui/README.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| # setup a D-Tale inance without need of authentication | |||
| ```bash | |||
| cd Vulnerable/ | |||
Contributor
There was a problem hiding this comment.
Suggested change
| cd Vulnerable/ |
dtale/exposed_ui/Dockerfile
Outdated
| @@ -0,0 +1,11 @@ | |||
| FROM python:3.7 | |||
Contributor
There was a problem hiding this comment.
This does not build correctly on my machine, I bumped it to python:3.10 and it builds without issues now. Was there any specific reason to leave it to 3.7?
Suggested change
| FROM python:3.7 | |
| FROM python:3.10 |
dtale/exposed_ui/README.md
Outdated
Comment on lines
10
to
14
| curl 'http://127.0.0.1:40000/dtale/upload' \ | ||
| -X POST \ | ||
| -H 'Content-Type: multipart/form-data; boundary=----geckoformboundaryb38fffc548bd5dad82328985c3f223d4' \ | ||
| --data-binary \ | ||
| $'------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="simple-dtale-data.csv"; filename="simple-dtale-data.csv"\r\nContent-Type: text/csv\r\n\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="header"\r\n\r\ntrue\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="separatorType"\r\n\r\ncomma\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4\r\nContent-Disposition: form-data; name="separator"\r\n\r\n\r\n------geckoformboundaryb38fffc548bd5dad82328985c3f223d4--\r\n' |
Contributor
There was a problem hiding this comment.
I get the same issue of the detector, already commented it here: google/tsunami-security-scanner-plugins#673 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google/tsunami-security-scanner-plugins#561