pybind: Remove in-place mutation operators from hashable types#629
Merged
Conversation
In-place operators (__iadd__, __isub__, __imul__, __itruediv__) mutate the object, which corrupts dict/set entries if the object is used as a key. Without them, +=, -=, *=, /= fall back to the non-mutating binary operators + rebinding, so the syntax still works. Affects S1Angle, R2Point, and S2Point. Rename the corresponding tests to test_add_assign / test_sub_assign / test_mul_assign / test_div_assign to reflect the fallback semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-place arithmetic operators (
__iadd__,__isub__,__imul__,__itruediv__) mutate the object in place. If the object is used as a dictionary key or set member, mutation corrupts the hash table entry.Removes these operators from
S1Angle,R2Point, andS2Point. Augmented assignment (+=,-=,*=,/=) still works: Python falls back to the binary operator and rebinds the variable, soa += bis equivalent toa = a + b.Tests renamed to
test_add_assign/test_sub_assign/test_mul_assign/test_div_assignto reflect the fallback semantics.