Skip to content

CMakeLists.txt: Define NOMINMAX for Windows #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmr wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

CMakeLists.txt: Define NOMINMAX for Windows #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,19 @@ if (WITH_PYTHON)
find_package(Python3 COMPONENTS Interpreter Development.Module)
endif()

# Platform-specific.
if (WIN32)
# Make sure Windows doesn't define min/max macros that interfere with STL
add_definitions(-DNOMINMAX)
endif()

# Compiler-specific (MSVC/clang/...).
if (MSVC)
# Use unsigned characters
add_definitions(-J)
# Make sure cmath header defines things like M_PI
# C++20 defines `std::numbers::pi`, but we want to work with C++17.
add_definitions(-D_USE_MATH_DEFINES)
# Make sure Windows doesn't define min/max macros that interfere with STL
add_definitions(-DNOMINMAX)
else()
# Avoid megabytes of warnings like:
# util/math/vector.h:178:16: warning: optimization attribute on
Expand Down
Loading