Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| #include "absl/container/fixed_array.h" // IWYU pragma: keep | ||
| #include "absl/numeric/bits.h" // IWYU pragma: keep | ||
| #endif | ||
|
|
||
| namespace exactfloat { | ||
|
|
||
| using std::max; |
There was a problem hiding this comment.
using std::abs; etc would be more consistent with the current coding style. Does that work?
|
Also, there are conflicts that need to be resolved. |
|
Does #555 work for you? |
|
I've been very busy with other projects recently; my feelings won't be hurt at all if someone beats me to the punch on figuring out how to translate this patch from And RE |
For some reason, Microsoft's compiler doesn't seem to infer these overloads correctly. This patch allows successful compilation of v0.13.1.