Skip to content

MSVC Fix#545

Open
James-E-A wants to merge 1 commit intogoogle:masterfrom
James-E-A:feature/msvc-fix
Open

MSVC Fix#545
James-E-A wants to merge 1 commit intogoogle:masterfrom
James-E-A:feature/msvc-fix

Conversation

@James-E-A
Copy link
Copy Markdown

For some reason, Microsoft's compiler doesn't seem to infer these overloads correctly. This patch allows successful compilation of v0.13.1.

For some reason, Microsoft's compiler doesn't seem to infer these
overloads correctly...
@google-cla
Copy link
Copy Markdown

google-cla bot commented Feb 19, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

#include "absl/container/fixed_array.h" // IWYU pragma: keep
#include "absl/numeric/bits.h" // IWYU pragma: keep
#endif

namespace exactfloat {

using std::max;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using std::abs; etc would be more consistent with the current coding style. Does that work?

@jmr
Copy link
Copy Markdown
Member

jmr commented Feb 20, 2026

Also, there are conflicts that need to be resolved.

@jmr
Copy link
Copy Markdown
Member

jmr commented Mar 23, 2026

Does #555 work for you?

@James-E-A
Copy link
Copy Markdown
Author

I've been very busy with other projects recently; my feelings won't be hurt at all if someone beats me to the punch on figuring out how to translate this patch from v0.13.1 — which is still the latest release! Is there any possibility of doing a .2 bump with just this patch? — to whatever's going on on master. If not, I expect to have this checked out again by mid-April.

And RE using std::abs; I am also not familiar with this codebase or C++ generally; if there's alleged a prettier alternative fix, I have nothing to say in defense of my own original approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants