Use license name for license info when license url is empty #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Can someone please help review this pull request? Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the artifact only declares license name, and the license url is empty. This results in the empty page for such artifact in the Google Play OssLicenseActivity. An example of such artifact is com.microsoft.identity:common: https://repo1.maven.org/maven2/com/microsoft/identity/common/17.0.0/common-17.0.0.pom, where only a
<name>MIT License<\name>tag is provided. I think we should display the name tag if the license tag is absent.Use license name as a fallback when license url is not available to make sure there is always something to display in the license.