Skip to content

fix: use subprocess instead of os.system in set_sysctls.py #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use subprocess instead of os.system in set_sysctls.py #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions gtests/net/tcp/common/set_sysctls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
__author__ = ('brakmo@google.com (Lawrence Brakmo)')

import os
import subprocess
import stat
import sys

filename = '/tmp/sysctl_restore_%s.sh' % os.environ['PACKETDRILL_PID']
Expand All @@ -31,11 +31,12 @@
# sysctl[0] contains the proc-file name, sysctl[1] the new value

# read current value and add restore command to file
cur_val = subprocess.check_output(['cat', sysctl[0]], universal_newlines=True)
with open(sysctl[0], 'r') as f:
cur_val = f.read()
print('echo "%s" > %s' % (cur_val.strip(), sysctl[0]), file=restore_file)

# set new value
cmd = 'echo "%s" > %s' % (sysctl[1], sysctl[0])
os.system(cmd)
with open(sysctl[0], 'w') as f:
f.write(sysctl[1] + '\n')

os.system('chmod u+x %s' % filename)
os.chmod(filename, os.stat(filename).st_mode | stat.S_IXUSR)