[PowerPlay] Integrate Audio Effect Into PowerPlay #2380
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Copyright 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.oboe.samples.powerplay.effects | ||
|
Collaborator
There was a problem hiding this comment. nit, please add copyright declaration for all new added files. |
||
|
|
||
| import android.media.audiofx.BassBoost | ||
| import android.util.Log | ||
|
|
||
| class BassBoostManager(sessionId: Int) { | ||
| private val TAG = "BassBoostManager" | ||
| private var bassBoost: BassBoost? = null | ||
|
|
||
| init { | ||
| try { | ||
| bassBoost = BassBoost(0, sessionId).apply { | ||
| enabled = true | ||
| } | ||
| Log.i(TAG, "BassBoost created for session $sessionId") | ||
| } catch (e: Exception) { | ||
| Log.e(TAG, "Failed to create BassBoost", e) | ||
| } | ||
| } | ||
|
|
||
| val isAvailable: Boolean get() = bassBoost != null | ||
|
|
||
| fun setStrength(strength: Short) { | ||
| if (bassBoost?.strengthSupported == true) { | ||
| bassBoost?.setStrength(strength) | ||
| } | ||
| } | ||
|
|
||
| fun getStrength(): Short = bassBoost?.roundedStrength ?: 0 | ||
|
|
||
| fun release() { | ||
| bassBoost?.release() | ||
| bassBoost = null | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Copyright 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.oboe.samples.powerplay.effects | ||
|
|
||
| import android.media.audiofx.AudioEffect | ||
| import android.media.audiofx.BassBoost | ||
| import android.media.audiofx.Equalizer | ||
| import android.media.audiofx.LoudnessEnhancer | ||
|
|
||
| import android.util.Log | ||
| import java.util.UUID | ||
|
|
||
| class EffectsController { | ||
| private val TAG = "EffectsController" | ||
|
|
||
| var equalizer: EqualizerManager? = null | ||
| private set | ||
| var bassBoost: BassBoostManager? = null | ||
| private set | ||
| var loudness: LoudnessManager? = null | ||
| private set | ||
|
|
||
| fun initialize(sessionId: Int) { | ||
| if (sessionId <= 0) { | ||
| Log.w(TAG, "Invalid session ID $sessionId, cannot initialize effects") | ||
| return | ||
| } | ||
|
|
||
| Log.i(TAG, "Initializing effects for session $sessionId") | ||
|
|
||
| if (isEffectSupported(Equalizer.EFFECT_TYPE_EQUALIZER)) { | ||
| equalizer = EqualizerManager(sessionId) | ||
| } else { | ||
| Log.w(TAG, "Equalizer not supported") | ||
| } | ||
|
|
||
| if (isEffectSupported(BassBoost.EFFECT_TYPE_BASS_BOOST)) { | ||
| bassBoost = BassBoostManager(sessionId) | ||
| } else { | ||
| Log.w(TAG, "Bass Boost not supported") | ||
| } | ||
|
|
||
| if (isEffectSupported(LoudnessEnhancer.EFFECT_TYPE_LOUDNESS_ENHANCER)) { | ||
| loudness = LoudnessManager(sessionId) | ||
| } else { | ||
| Log.w(TAG, "Loudness Enhancer not supported") | ||
| } | ||
| } | ||
|
|
||
| private fun isEffectSupported(effectTypeUuid: UUID): Boolean { | ||
| val descriptors = AudioEffect.queryEffects() | ||
| for (descriptor in descriptors) { | ||
| if (descriptor.type == effectTypeUuid) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| fun release() { | ||
| Log.i(TAG, "Releasing effects") | ||
| equalizer?.release() | ||
| bassBoost?.release() | ||
| loudness?.release() | ||
| equalizer = null | ||
| bassBoost = null | ||
| loudness = null | ||
| } | ||
|
|
||
| enum class EffectType { | ||
| EQUALIZER, BASS_BOOST, LOUDNESS | ||
| } | ||
|
|
||
| fun getSupportedEffects(): List<EffectType> { | ||
| val list = mutableListOf<EffectType>() | ||
| if (equalizer?.isAvailable == true) list.add(EffectType.EQUALIZER) | ||
| if (bassBoost?.isAvailable == true) list.add(EffectType.BASS_BOOST) | ||
| if (loudness?.isAvailable == true) list.add(EffectType.LOUDNESS) | ||
| return list | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By allocating session id, all the paths will not be on a low latency path...
Please try playing with the settings in OboeTester to see what happens when you do this.
That's why we have been telling folks to add their own effects in the app if possible and not rely on platform effects.
BassBoost, Equalizer, and Loudness effects can easily be written without using the AudioEffect from Android. The app can easily implement this as it renders audio