Skip to content

Conversation

@gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented Dec 8, 2025

This PR finds instances where we previously checked if the feature flag for contacts-prohibited was set and removes those checks, making the contacts-prohibited behavior the only behavior. Because the tests didn't have that feature flag set, this means we need to change a ton of tests to remove contact references.


This change is Reviewable

@gbrodman gbrodman force-pushed the alwaysProhibitContacts branch 2 times, most recently from de1434b to 2357c4c Compare December 9, 2025 18:09
@gbrodman gbrodman requested a review from weiminyu December 9, 2025 19:22
Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 180 of 180 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/batch/RemoveAllDomainContactsAction.java line 112 at r1 (raw file):

        tm().transact(() -> FeatureFlag.isActiveNow(MINIMUM_DATASET_CONTACTS_PROHIBITED)),
        "Minimum dataset migration must be completed prior to running this action");
    response.setContentType(PLAIN_TEXT_UTF_8);

Should this line remain?

Code quote:

response.setContentType(PLAIN_TEXT_UTF_8);

Copy link
Collaborator Author

@gbrodman gbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @weiminyu)


core/src/main/java/google/registry/batch/RemoveAllDomainContactsAction.java line 112 at r1 (raw file):

Previously, weiminyu (Weimin Yu) wrote…

Should this line remain?

yeah probably, though this entire action is deleted in #2872

This PR finds instances where we previously checked if the feature flag
for contacts-prohibited was set and removes those checks, making the
contacts-prohibited behavior the only behavior. Because the tests didn't
have that feature flag set, this means we need to change a ton of tests
to remove contact references.
@gbrodman gbrodman force-pushed the alwaysProhibitContacts branch from 2357c4c to 5d9d89e Compare December 10, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants