lc3: setup_decoder: allow downsampling from source #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a bug where downsampling from received data `sr_hz` to pcm data `sr_pcm_hz` is disallowed for the decoder, which causes the setup to fail. The encoder, on the other hand, sources the data from pcm, and allows downsampling from that to the other end. Assuming symmetry w.r.t. the direction of downsampling, the comparison operator should be flipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a bug where downsampling from received data
sr_hzto pcm datasr_pcm_hzis disallowed for the decoder, which causes the setup to fail.The encoder, on the other hand, sources the data from pcm, and allows downsampling from that to the other end.
Assuming symmetry w.r.t. the direction of downsampling, the comparison operator should be flipped.